linux-kernel - Re: [PATCH v10 09/14] platform/x86: Rename alienware-wmi.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D7PSNJVIIQ6Q.99BIJKP7H2YU@gmail.com>
Date: Tue, 11 Feb 2025 12:31:34 -0500
From: "Kurt Borja" <kuurtb@...il.com>
To: "Andy Shevchenko" <andriy.shevchenko@...el.com>
Cc: <platform-driver-x86@...r.kernel.org>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>, "Armin Wolf" <W_Armin@....de>, "Mario
 Limonciello" <mario.limonciello@....com>, "Hans de Goede"
 <hdegoede@...hat.com>, <Dell.Client.Kernel@...l.com>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 09/14] platform/x86: Rename alienware-wmi.c

Hi Andy,

Thank you for your review!

On Tue Feb 11, 2025 at 11:41 AM -05, Andy Shevchenko wrote:
> On Fri, Feb 07, 2025 at 10:46:05AM -0500, Kurt Borja wrote:
>> Rename alienware-wmi to support upcoming split.
>
> (the change that is caught by my eye and induced this review session)
>
> ...
>
>>  obj-$(CONFIG_ALIENWARE_WMI)		+= alienware-wmi.o
>> +alienware-wmi-objs			:= alienware-wmi-base.o
>
> objs is incorrect! Please use correct y instead.

I want to understand what is exactly wrong here. This `objs` pattern is
used a lot in this file, so I just copied it. For example [1].

Is it wrong to do it here for a single file? Is it wrong to do it at
all?

My goal is to split the file, but link it all together in a single
module.

[1] https://elixir.bootlin.com/linux/v6.14-rc2/source/drivers/platform/x86/dell/Makefile#L14

-- 
 ~ Kurt

>
>>  obj-$(CONFIG_DCDBAS)			+= dcdbas.o
>>  obj-$(CONFIG_DELL_LAPTOP)		+= dell-laptop.o
>>  obj-$(CONFIG_DELL_RBTN)			+= dell-rbtn.o