linux-kernel - Re: [PATCH v10 07/14] platform/x86: alienware-wmi: Split DMI table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D7PT472556KX.JXEW7Q9EFR1U@gmail.com>
Date: Tue, 11 Feb 2025 12:53:18 -0500
From: "Kurt Borja" <kuurtb@...il.com>
To: "Andy Shevchenko" <andriy.shevchenko@...el.com>
Cc: <platform-driver-x86@...r.kernel.org>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>, "Armin Wolf" <W_Armin@....de>, "Mario
 Limonciello" <mario.limonciello@....com>, "Hans de Goede"
 <hdegoede@...hat.com>, <Dell.Client.Kernel@...l.com>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 07/14] platform/x86: alienware-wmi: Split DMI table

On Tue Feb 11, 2025 at 11:39 AM -05, Andy Shevchenko wrote:
> On Fri, Feb 07, 2025 at 10:46:03AM -0500, Kurt Borja wrote:
>> Split thermal features into a new DMI table to support upcoming file
>> split. While at it:
>> 
>> Rename quirk_entry -> alienfx_quirks,
>> Rename quirks -> alienfx
>> 
>> and change hdmi_mux, amplifier and deepslp types to bool, because they are
>> already being implicitly used as bools.
>
> ...
>
>> +struct awcc_quirks {
>> +	bool pprof;
>> +	bool gmode;
>
> Wouldn't it be better to have them as bitfields?

Yes, I like this.

>
> 	unsigned int pprof:1;
> 	...
>
> On 5th quirk (if ever happens) this will gain memory.
>
>> +};

-- 
 ~ Kurt