linux-kernel - Re: [PATCH v10 10/14] platform/x86: Add alienware-wmi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D7PT4KOCJTP4.2LJWH5X14M2D3@gmail.com>
Date: Tue, 11 Feb 2025 12:53:48 -0500
From: "Kurt Borja" <kuurtb@...il.com>
To: "Andy Shevchenko" <andriy.shevchenko@...el.com>
Cc: <platform-driver-x86@...r.kernel.org>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>, "Armin Wolf" <W_Armin@....de>, "Mario
 Limonciello" <mario.limonciello@....com>, "Hans de Goede"
 <hdegoede@...hat.com>, <Dell.Client.Kernel@...l.com>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 10/14] platform/x86: Add alienware-wmi.h

On Tue Feb 11, 2025 at 11:45 AM -05, Andy Shevchenko wrote:
> On Fri, Feb 07, 2025 at 10:46:06AM -0500, Kurt Borja wrote:
>> Add a header file for alienware-wmi with shared resources to support the
>> upcoming file split.
>
> ...
>
>>  static const struct attribute_group *alienfx_groups[] = {
>>  	&zone_attribute_group,
>> -	&hdmi_attribute_group,
>> -	&amplifier_attribute_group,
>> -	&deepsleep_attribute_group,
>> +	WMAX_DEV_GROUPS
>>  	NULL
>
> I don't like this change as it makes code harder to understand (at one glance
> you can't answer the question "what are the groups that being listed here?".
>
>>  };
>
> ...
>
>> +#include <linux/leds.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/wmi.h>
>
> This should follow IWYU principle, now it looks like random stuff which this
> header does *not* use.

I will check these.

-- 
 ~ Kurt