linux-kernel - Re: [PATCH v5 23/34] drm/mediatek: mtk_hdmi: Move output init to mtk_hdmi_register_audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <69c2d145662345b160718feb5966ffa06030d607.camel@mediatek.com>
Date: Tue, 11 Feb 2025 02:25:32 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>
CC: "robh@...nel.org" <robh@...nel.org>, "jie.qiu@...iatek.com"
	<jie.qiu@...iatek.com>, "kernel@...labora.com" <kernel@...labora.com>,
	"simona@...ll.ch" <simona@...ll.ch>, "mripard@...nel.org"
	<mripard@...nel.org>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	Lewis Liao (廖柏鈞) <Lewis.Liao@...iatek.com>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, Jitao Shi (石记涛)
	<jitao.shi@...iatek.com>, TommyYL Chen (陳彥良)
	<TommyYL.Chen@...iatek.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "airlied@...il.com" <airlied@...il.com>,
	Ives Chenjh (陳俊弘) <Ives.Chenjh@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "junzhi.zhao@...iatek.com"
	<junzhi.zhao@...iatek.com>
Subject: Re: [PATCH v5 23/34] drm/mediatek: mtk_hdmi: Move output init to
 mtk_hdmi_register_audio_driver()

On Mon, 2025-02-10 at 12:15 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> Il 07/02/25 06:46, CK Hu (胡俊光) ha scritto:
> > Hi, Angelo:
> > 
> > On Mon, 2025-01-13 at 15:52 +0100, AngeloGioacchino Del Regno wrote:
> > > External email : Please do not click links or open attachments until you have verified the sender or the content.
> > > 
> > > 
> > > In preparation for moving the common bits of this driver, merge the
> > > contents of mtk_hdmi_output_init in mtk_hdmi_register_audio_driver
> > > function to aggregate all of the initial audio setup together in
> > > the same function and to make it clear that all of the setup that
> > > is performed in mtk_hdmi_output_init is specifically related only
> > > to audio and not video.
> > > 
> > > While at it, also remove the "%s driver bound to HDMI" debugging
> > > print disguised as informative.
> > > 
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> > > ---
> > >   drivers/gpu/drm/mediatek/mtk_hdmi.c | 28 ++++++++--------------------
> > >   1 file changed, 8 insertions(+), 20 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > index e2393f7558f9..4345c91e92e7 100644
> > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > @@ -1025,20 +1025,6 @@ static int mtk_hdmi_setup_vendor_specific_infoframe(struct mtk_hdmi *hdmi,
> > >          return 0;
> > >   }
> > > 
> > > -static int mtk_hdmi_output_init(struct mtk_hdmi *hdmi)
> > > -{
> > > -       struct hdmi_audio_param *aud_param = &hdmi->aud_param;
> > > -
> > > -       aud_param->aud_codec = HDMI_AUDIO_CODING_TYPE_PCM;
> > > -       aud_param->aud_sample_size = HDMI_AUDIO_SAMPLE_SIZE_16;
> > > -       aud_param->aud_input_type = HDMI_AUD_INPUT_I2S;
> > > -       aud_param->aud_i2s_fmt = HDMI_I2S_MODE_I2S_24BIT;
> > > -       aud_param->aud_mclk = HDMI_AUD_MCLK_128FS;
> > > -       aud_param->aud_input_chan_type = HDMI_AUD_CHAN_TYPE_2_0;
> > > -
> > > -       return 0;
> > > -}
> > > -
> > >   static void mtk_hdmi_audio_enable(struct mtk_hdmi *hdmi)
> > >   {
> > >          mtk_hdmi_hw_send_aud_packet(hdmi, true);
> > > @@ -1616,6 +1602,7 @@ static void mtk_hdmi_unregister_audio_driver(void *data)
> > >   static int mtk_hdmi_register_audio_driver(struct device *dev)
> > >   {
> > >          struct mtk_hdmi *hdmi = dev_get_drvdata(dev);
> > > +       struct hdmi_audio_param *aud_param = &hdmi->aud_param;
> > >          struct hdmi_codec_pdata codec_data = {
> > >                  .ops = &mtk_hdmi_audio_codec_ops,
> > >                  .max_i2s_channels = 2,
> > > @@ -1625,6 +1612,13 @@ static int mtk_hdmi_register_audio_driver(struct device *dev)
> > >          };
> > >          int ret;
> > > 
> > > +       aud_param->aud_codec = HDMI_AUDIO_CODING_TYPE_PCM;
> > > +       aud_param->aud_sample_size = HDMI_AUDIO_SAMPLE_SIZE_16;
> > > +       aud_param->aud_input_type = HDMI_AUD_INPUT_I2S;
> > > +       aud_param->aud_i2s_fmt = HDMI_I2S_MODE_I2S_24BIT;
> > > +       aud_param->aud_mclk = HDMI_AUD_MCLK_128FS;
> > > +       aud_param->aud_input_chan_type = HDMI_AUD_CHAN_TYPE_2_0;
> > > +
> > >          hdmi->audio_pdev = platform_device_register_data(dev,
> > >                                                           HDMI_CODEC_DRV_NAME,
> > >                                                           PLATFORM_DEVID_AUTO,
> > > @@ -1638,7 +1632,6 @@ static int mtk_hdmi_register_audio_driver(struct device *dev)
> > >          if (ret)
> > >                  return ret;
> > > 
> > > -       DRM_INFO("%s driver bound to HDMI\n", HDMI_CODEC_DRV_NAME);
> > 
> > This modification is not related to the title. If necessary, separate this to another patch.
> > But I don't know why remove this. Could you explain more?
> > 
> 
> It's a cleanup... if every driver in the kernel said "bound to" or "registered",
> the kernel log would be extremely long and unreadable... so that's why this print
> was removed.
> 
> I can separate this to a different patch if you want, even though that'd be
> overkill, imo.

It's important to reduce kernel log.
After separate this part, if someone want to backport this to reduce log, it would not backport the whole patch.
So, let's separate it.

Regards,
CK

> 
> Cheers,
> Angelo
> 
> > Regards,
> > CK
> > 
> > >          return 0;
> > >   }
> > > 
> > > @@ -1667,11 +1660,6 @@ static int mtk_hdmi_probe(struct platform_device *pdev)
> > >          mutex_init(&hdmi->update_plugged_status_lock);
> > >          platform_set_drvdata(pdev, hdmi);
> > > 
> > > -       ret = mtk_hdmi_output_init(hdmi);
> > > -       if (ret)
> > > -               return dev_err_probe(dev, ret,
> > > -                                    "Failed to initialize hdmi output\n");
> > > -
> > >          ret = mtk_hdmi_register_audio_driver(dev);
> > >          if (ret)
> > >                  return dev_err_probe(dev, ret,
> > > --
> > > 2.47.0
> > > 
> > 
>