linux-kernel - RE: [PATCH v5 1/5] cdx: export the symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SA1PR12MB894784C196AFCAB18B86130C81FD2@SA1PR12MB8947.namprd12.prod.outlook.com>
Date: Tue, 11 Feb 2025 05:29:36 +0000
From: "Datta, Shubhrajyoti" <shubhrajyoti.datta@....com>
To: Borislav Petkov <bp@...en8.de>
CC: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Tony Luck <tony.luck@...el.com>, James
 Morse <james.morse@....com>, Mauro Carvalho Chehab <mchehab@...nel.org>,
	Robert Richter <rric@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "git (AMD-Xilinx)" <git@....com>
Subject: RE: [PATCH v5 1/5] cdx: export the symbols

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Borislav Petkov <bp@...en8.de>
> Sent: Thursday, January 16, 2025 3:57 AM
> To: Datta, Shubhrajyoti <shubhrajyoti.datta@....com>
> Cc: Krzysztof Kozlowski <krzk@...nel.org>; Rob Herring <robh@...nel.org>;
> Conor Dooley <conor+dt@...nel.org>; Tony Luck <tony.luck@...el.com>; James
> Morse <james.morse@....com>; Mauro Carvalho Chehab
> <mchehab@...nel.org>; Robert Richter <rric@...nel.org>; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org; linux-edac@...r.kernel.org;
> git (AMD-Xilinx) <git@....com>
> Subject: Re: [PATCH v5 1/5] cdx: export the symbols
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Mon, Jan 06, 2025 at 11:03:54AM +0530, Shubhrajyoti Datta wrote:
> > export the symbols for modules.
>
> Which modules are going to use those? Why?

The versal_rpmsg_edac is going to use the calls.
>
> Why is this patch in this set?

EDAC: Versal NET: Add support for error notification
Uses the calls
So I thought of adding in same series.

>
> This commit message is largely inadequate. Your other commit messages too.
>
> Yeah, the goal is for our commit messages to be as clear to humans as possible,
> even for people who do not have intimate knowledge of the matter.
>
> And, more importantly, when we start doing git archeology months, years from now,
> it should be perfectly clear why a commit was done.
>
> So please try to explain the issue in a clear and detailed way.

Will update the commit message and resend

>
> People and you yourself will be thankful for it.
>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette