[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250115222702.GCZ4g2NhPjxGq0OmeC@fat_crate.local>
Date: Wed, 15 Jan 2025 23:27:02 +0100
From: Borislav Petkov <bp@...en8.de>
To: Shubhrajyoti Datta <shubhrajyoti.datta@....com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Tony Luck <tony.luck@...el.com>,
James Morse <james.morse@....com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Robert Richter <rric@...nel.org>, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-edac@...r.kernel.org, git@....com
Subject: Re: [PATCH v5 1/5] cdx: export the symbols
On Mon, Jan 06, 2025 at 11:03:54AM +0530, Shubhrajyoti Datta wrote:
> export the symbols for modules.
Which modules are going to use those? Why?
Why is this patch in this set?
This commit message is largely inadequate. Your other commit messages too.
Yeah, the goal is for our commit messages to be as clear to humans as
possible, even for people who do not have intimate knowledge of the matter.
And, more importantly, when we start doing git archeology months, years from
now, it should be perfectly clear why a commit was done.
So please try to explain the issue in a clear and detailed way.
People and you yourself will be thankful for it.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists