linux-kernel - RE: [PATCH v2 1/3] x86/mce/inject: Remove call to mce_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB713403A5AC3B0699B56A552F89FD2@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Tue, 11 Feb 2025 07:03:47 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Nikolay Borisov <nik.borisov@...e.com>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>, "Luck, Tony" <tony.luck@...el.com>
Subject: RE: [PATCH v2 1/3] x86/mce/inject: Remove call to mce_notify_irq()

> From: Nikolay Borisov <nik.borisov@...e.com>
> [...]
> --- a/arch/x86/kernel/cpu/mce/core.c
> +++ b/arch/x86/kernel/cpu/mce/core.c
> @@ -584,6 +584,28 @@ bool mce_is_correctable(struct mce *m)  }
> EXPORT_SYMBOL_GPL(mce_is_correctable);
> 
> +/*
> + * Notify the user(s) about new machine check events.
> + * Can be called from interrupt context, but not from machine check/NMI
> + * context.
> + */
> +static int mce_notify_irq(void)

Why make mce_notify_irq() return an int?

> [...]
> -/*
> - * Notify the user(s) about new machine check events.
> - * Can be called from interrupt context, but not from machine check/NMI
> - * context.
> - */
> -bool mce_notify_irq(void)
> [...]