linux-kernel - RE: [PATCH v2 2/3] x86/mce: Move message printing from mce_notify_irq to mce_early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB7134DFC46AD440D42C5DB90489FD2@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Tue, 11 Feb 2025 07:10:03 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Nikolay Borisov <nik.borisov@...e.com>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>, "Luck, Tony" <tony.luck@...el.com>
Subject: RE: [PATCH v2 2/3] x86/mce: Move message printing from mce_notify_irq
 to mce_early_notifier()

> From: Nikolay Borisov <nik.borisov@...e.com>
> [...]
> Subject: [PATCH v2 2/3] x86/mce: Move message printing from mce_notify_irq
> to mce_early_notifier()
> 
> Informing the user that an MCE has been logged from mce_notify_irq() is
> somewhat misleading because whether the MCE has been logged actually
> depends on whether CONFIG_X86_MCELOG_LEGACY is turned on or not.
> 
> Furthermore it was reported that actually having a message triggered when
> an MCE is generated can be helpful in certain scenarios. Improve the situation
> by lifting the printing to the generic
> mce_early_notifier() as it's executed always and is independent of any
> compile-time option.
> 
> Link:
> https://lore.kernel.org/all/CY8PR11MB7134D97F82DC001AE009637889E32@
> CY8PR11MB7134.namprd11.prod.outlook.com/
> Signed-off-by: Nikolay Borisov <nik.borisov@...e.com>

LGTM. Thanks!

    Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>