linux-kernel - Re: [PATCH v2] accel/amdxdna: Add missing include linux/slab.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d459faf0-a180-496a-a809-db5b5a247e94@linux.intel.com>
Date: Tue, 11 Feb 2025 09:47:11 +0100
From: Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>
To: Su Hui <suhui@...china.com>, min.ma@....com, lizhi.hou@....com,
 ogabbay@...nel.org
Cc: quic_jhugo@...cinc.com, George.Yang@....com,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] accel/amdxdna: Add missing include linux/slab.h

Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>

On 2/11/2025 2:53 AM, Su Hui wrote:
> When compiling without CONFIG_IA32_EMULATION, there can be some errors:
> 
> drivers/accel/amdxdna/amdxdna_mailbox.c: In function ‘mailbox_release_msg’:
> drivers/accel/amdxdna/amdxdna_mailbox.c:197:2: error: implicit declaration
> of function ‘kfree’.
>   197 |  kfree(mb_msg);
>       |  ^~~~~
> drivers/accel/amdxdna/amdxdna_mailbox.c: In function ‘xdna_mailbox_send_msg’:
> drivers/accel/amdxdna/amdxdna_mailbox.c:418:11: error:implicit declaration
> of function ‘kzalloc’.
>   418 |  mb_msg = kzalloc(sizeof(*mb_msg) + pkg_size, GFP_KERNEL);
>       |           ^~~~~~~
> 
> Add the missing include.
> 
> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
> Signed-off-by: Su Hui <suhui@...china.com>
> Reviewed-by: Lizhi Hou <lizhi.hou@....com>
> ---
> v2:
>  - move the header to the include block above and keep it sorted(Jacek Lawrynowicz).
> 
>  drivers/accel/amdxdna/amdxdna_mailbox.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
> index 814b16bb1953..e5301fac1397 100644
> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
> @@ -8,6 +8,7 @@
>  #include <linux/bitfield.h>
>  #include <linux/interrupt.h>
>  #include <linux/iopoll.h>
> +#include <linux/slab.h>
>  #include <linux/xarray.h>
>  
>  #define CREATE_TRACE_POINTS