linux-kernel - Re: [PATCH v2 0/6] usb: serial: mos7840: Fix coding style warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6sVIIzaRP_PhzpL@hovoldconsulting.com>
Date: Tue, 11 Feb 2025 10:15:12 +0100
From: Johan Hovold <johan@...nel.org>
To: Tony Chung <tony467913@...il.com>
Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 0/6] usb: serial: mos7840: Fix coding style warnings

Hi Tony,

and sorry about the late feedback on this one and your other series for
this driver.

On Fri, Oct 25, 2024 at 02:17:06PM +0800, Tony Chung wrote:
> This patch series fix all the coding style warnings shown by checkpatch.pl

Checkpatch should generally not be run on code that is already in the
tree. It's meant as a tool to be run on patches before submitting them
and you always have to use your own judgement whether its output makes
sense or not.

That said, since you are actually doing real work on this driver and
there certainly are some real style issues with this driver, I'll review
these.

> I have tested Patch v2 and it has no driver build warnings.
> Please have a look and let me know if something is wrong. Thanks.
> 
> Tony Chung (6):
>   driver: usb: serial: mos7840: fix warnings "no space before tabs"
>   drivers: usb: serial: mos7840: Fix Block comments coding style
>     warnings
>   drivers: usb: serial: mos7840: fix coding style warnings
>   drivers: usb: serial: mos7840: using '__func__' to replace function
>     name in dbg message
>   drivers: usb: serial: mos7840: replace 'unsigned' w/ 'unsigned int'
>   drivers: usb: serial: mos7840: fix the quoted string split across
>     lines

First, please try to use the established patch prefix for the drivers
you are changing (e.g. as can often be determined by running git log
--oneline on the files in question). In this case

	USB: serial: mos7840: ...

Second, please rephrase the patch summaries and commit messages so that
they don't give the impression that you're doing this just to make
checkpatch happy. Instead say, for example:

	Add newlines after declarations to improve readability.

as that is a valid motivation for doing clean ups like this as part of
other work on the driver (and try to rephrase as "clean up" instead of
"fix" as I think the latter should be reserved for bug fixes).

Johan