linux-kernel - Re: [PATCH v2 1/6] driver: usb: serial: mos7840: fix style warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6sWYSYbNNm7-jcn@hovoldconsulting.com>
Date: Tue, 11 Feb 2025 10:20:33 +0100
From: Johan Hovold <johan@...nel.org>
To: Tony Chung <tony467913@...il.com>
Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 1/6] driver: usb: serial: mos7840: fix style warnings

On Fri, Oct 25, 2024 at 02:17:08PM +0800, Tony Chung wrote:
> fix "no space before tabs" coding style warnings.

Perhaps rephrase as:

	Replace spaces before tabs, which some editors and pagers
	highlight as errors.

Getting rid of those red higlights I see in vim should be motivation
enough here (again, as you're doing other changes to the driver).
 
> Signed-off-by: Tony Chung <tony467913@...il.com>
> ---
>  drivers/usb/serial/mos7840.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index ca3da79af..dcaed0f26 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -220,7 +220,7 @@ struct moschip_port {
>  
>  /*
>   * mos7840_set_reg_sync
> - * 	To set the Control register by calling usb_fill_control_urb function
> + *	To set the Control register by calling usb_fill_control_urb function
>   *	by passing usb_sndctrlpipe function as parameter.
>   */
>  
> @@ -238,7 +238,7 @@ static int mos7840_set_reg_sync(struct usb_serial_port *port, __u16 reg,
>  
>  /*
>   * mos7840_get_reg_sync
> - * 	To set the Uart register by calling usb_fill_control_urb function by
> + *	To set the Uart register by calling usb_fill_control_urb function by
>   *	passing usb_rcvctrlpipe function as parameter.
>   */
>  
> @@ -1356,11 +1356,11 @@ static void mos7840_set_termios(struct tty_struct *tty,
>   * mos7840_get_lsr_info - get line status register info
>   *
>   * Purpose: Let user call ioctl() to get info when the UART physically
> - * 	    is emptied.  On bus types like RS485, the transmitter must
> - * 	    release the bus after transmitting. This must be done when
> - * 	    the transmit shift register is empty, not be done when the
> - * 	    transmit holding register is empty.  This functionality
> - * 	    allows an RS485 driver to be written in user space.
> + *	is emptied.  On bus types like RS485, the transmitter must
> + *	release the bus after transmitting. This must be done when
> + *	the transmit shift register is empty, not be done when the
> + *	transmit holding register is empty.  This functionality
> + *	allows an RS485 driver to be written in user space.

But perhaps you should keep the indentation here (all lines are aligned
under "Let") as the author intended.

Johan