linux-kernel - Re: [PATCH v2 2/6] drivers: usb: serial: mos7840: Fix Block comments coding style warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6sYCJEsTDth_Nld@hovoldconsulting.com>
Date: Tue, 11 Feb 2025 10:27:36 +0100
From: Johan Hovold <johan@...nel.org>
To: Tony Chung <tony467913@...il.com>
Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 2/6] drivers: usb: serial: mos7840: Fix Block comments
 coding style warnings

On Fri, Oct 25, 2024 at 02:17:10PM +0800, Tony Chung wrote:
> fix block comments coding style warnings.
> 1. Block comments use * on subsequent lines
> 2. Block comments use a trailing */ on a separate line

Just say something like:

	Clean up the style of the block comments.

or similar.

> Signed-off-by: Tony Chung <tony467913@...il.com>
> ---
>  drivers/usb/serial/mos7840.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index dcaed0f26..b1a794f99 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -282,7 +282,8 @@ static int mos7840_set_uart_reg(struct usb_serial_port *port, __u16 reg,
>  	struct usb_device *dev = port->serial->dev;
>  	val = val & 0x00ff;
>  	/* For the UART control registers, the application number need
> -	   to be Or'ed */
> +	 * to be Or'ed
> +	 */
>  	if (port->serial->num_ports == 2 && port->port_number != 0)
>  		val |= ((__u16)port->port_number + 2) << 8;
>  	else
> @@ -1539,8 +1540,9 @@ static int mos7840_port_probe(struct usb_serial_port *port)
>  	int pnum;
>  	__u16 Data;
>  
> -	/* we set up the pointers to the endpoints in the mos7840_open *
> -	 * function, as the structures aren't created yet.             */
> +	/* we set up the pointers to the endpoints in the mos7840_open

This style is only valid in networking code; the format for block
comments should generally be:

	/*
	 * ...
	 */
	 
> +	 * function, as the structures aren't created yet.
> +	 */
>  
>  	pnum = port->port_number;
>  
> @@ -1551,14 +1553,16 @@ static int mos7840_port_probe(struct usb_serial_port *port)
>  
>  	/* Initialize all port interrupt end point to port 0 int
>  	 * endpoint. Our device has only one interrupt end point
> -	 * common to all port */
> +	 * common to all port
> +	 */
>  
>  	mos7840_port->port = port;
>  	spin_lock_init(&mos7840_port->pool_lock);
>  
>  	/* minor is not initialised until later by
>  	 * usb-serial.c:get_free_serial() and cannot therefore be used
> -	 * to index device instances */
> +	 * to index device instances
> +	 */
>  	mos7840_port->port_num = pnum + 1;
>  	dev_dbg(&port->dev, "port->minor = %d\n", port->minor);
>  	dev_dbg(&port->dev, "mos7840_port->port_num = %d\n", mos7840_port->port_num);
> @@ -1591,7 +1595,8 @@ static int mos7840_port_probe(struct usb_serial_port *port)
>  		dev_dbg(&port->dev, "ControlReg Reading success val is %x, status%d\n", Data, status);
>  	Data |= 0x08;	/* setting driver done bit */
>  	Data |= 0x04;	/* sp1_bit to have cts change reflect in
> -			   modem status reg */
> +			 * modem status reg
> +			 */

Just drop the new line, this can be an exception to the 80 char rule if
you can't find a good way to rephrase this.

>  	/* Data |= 0x20; //rx_disable bit */
>  	status = mos7840_set_reg_sync(port,

Johan