linux-kernel - Re: [PATCH v2 5/6] drivers: usb: serial: mos7840: replace 'unsigned' w/ 'unsigned int'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6sY2lO3lmFCrKeb@hovoldconsulting.com>
Date: Tue, 11 Feb 2025 10:31:06 +0100
From: Johan Hovold <johan@...nel.org>
To: Tony Chung <tony467913@...il.com>
Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 5/6] drivers: usb: serial: mos7840: replace 'unsigned'
 w/ 'unsigned int'

On Fri, Oct 25, 2024 at 02:17:16PM +0800, Tony Chung wrote:
> Fix coding style "Prefer 'unsigned int' to bare use of 'unsigned'"
> 
> Signed-off-by: Tony Chung <tony467913@...il.com>
> ---
>  drivers/usb/serial/mos7840.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index 31ec2cf1b..d2cae6619 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -1201,7 +1201,7 @@ static void mos7840_change_port_settings(struct tty_struct *tty,
>  {
>  	struct usb_serial_port *port = mos7840_port->port;
>  	int baud;
> -	unsigned cflag;
> +	unsigned int cflag;

Just drop this one too.

You can follow this style suggestion in your own code, but there's
really no need to go around changing perfectly valid code just to
silence checkpatch.

Johan