linux-kernel - Re: [PATCH v2 4/6] drivers: usb: serial: mos7840: using '__func__' to replace function name in dbg message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025021133-smooth-villain-bed8@gregkh>
Date: Tue, 11 Feb 2025 10:32:14 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Johan Hovold <johan@...nel.org>
Cc: Tony Chung <tony467913@...il.com>, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 4/6] drivers: usb: serial: mos7840: using '__func__'
 to replace function name in dbg message

On Tue, Feb 11, 2025 at 10:29:22AM +0100, Johan Hovold wrote:
> On Fri, Oct 25, 2024 at 02:17:14PM +0800, Tony Chung wrote:
> > fix warning of Prefer '"%s...",__func__' to using 'function name'.
> > 
> > Signed-off-by: Tony Chung <tony467913@...il.com>
> > ---
> >  drivers/usb/serial/mos7840.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> > index b48a26468..31ec2cf1b 100644
> > --- a/drivers/usb/serial/mos7840.c
> > +++ b/drivers/usb/serial/mos7840.c
> > @@ -230,7 +230,7 @@ static int mos7840_set_reg_sync(struct usb_serial_port *port, __u16 reg,
> >  	struct usb_device *dev = port->serial->dev;
> >  
> >  	val = val & 0x00ff;
> > -	dev_dbg(&port->dev, "mos7840_set_reg_sync offset is %x, value %x\n", reg, val);
> > +	dev_dbg(&port->dev, "%s offset is %x, value %x\n", __func__, reg, val);
> 
> I suggest you just leave this as is.

__func__ should NEVER be added to dev_dbg() lines as it is already
available if the user want it.  Adding it explicitly to the string is
just redundant.

thanks,

greg k-h