linux-kernel - Re: [PATCH v2] platform: cznic: CZNIC_PLATFORMS should depend on MACH_ARMADA_38X || ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6aa243e1-6e25-46c8-b75a-d5e7bc1cd5a4@app.fastmail.com>
Date: Tue, 11 Feb 2025 12:04:13 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Geert Uytterhoeven" <geert+renesas@...der.be>,
 Marek Behún <kabel@...nel.org>,
 "Bartosz Golaszewski" <bartosz.golaszewski@...aro.org>,
 "Andy Shevchenko" <andy@...nel.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform: cznic: CZNIC_PLATFORMS should depend on
 MACH_ARMADA_38X || ARCH_MVEBU

On Tue, Feb 11, 2025, at 11:56, Geert Uytterhoeven wrote:
> CZ.NIC's Turris devices are based on Marvell Armada 385 or 3720 SoCs.
> Hence add dependencies on MACH_ARMADA_38X and ARCH_MVEBU, to prevent
> asking the user about these drivers when configuring a kernel that
> cannot run on an affected CZ.NIC Turris system.
>
> Fixes: 992f1a3d4e88498d ("platform: cznic: Add preliminary support for 
> Turris Omnia MCU")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> v2:
>   - Drop PPC_P2020 from the dependency list.

Looks good to me, one minor issue:

> @@ -6,6 +6,7 @@
> 
>  menuconfig CZNIC_PLATFORMS
>  	bool "Platform support for CZ.NIC's Turris hardware"
> +	depends on MACH_ARMADA_38X || ARCH_MVEBU || COMPILE_TEST

Technically the MACH_ARMADA_38X check is redundant here, as that
already requires ARCH_MVEBU.

     Arnd