linux-kernel - Re: [PATCH RESEND 3/5] leds: leds-st1202: spacing and proofreading editing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CWLP123MB54734806C2F211C814B31D56C5FC2@CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM>
Date: Wed, 12 Feb 2025 14:28:26 +0000 (GMT)
From: Manuel Fombuena <fombuena@...look.com>
To: Lee Jones <lee@...nel.org>
cc: pavel@....cz, corbet@....net, linux-leds@...r.kernel.org, 
    linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 3/5] leds: leds-st1202: spacing and proofreading
 editing


On Tue, 11 Feb 2025, Lee Jones wrote:

> > +#define ST1202_MILLIS_PATTERN_DUR_MAX		5660
> > +#define ST1202_MILLIS_PATTERN_DUR_MIN		22
> > +#define ST1202_PATTERN_DUR					0x16
> > +#define ST1202_PATTERN_PWM					0x1E
> > +#define ST1202_PATTERN_REP					0x15
> 
> Why are you making this change?
> 
> The spacings went from being okay to too large.

Originally the code uses blank spaces for alignment, but changing it to 
tabs leads to inconsistency across viewers / editors so I will just drop 
it. 

--
Manuel Fombuena <fombuena@...look.com>