linux-kernel - Re: [PATCH RESEND 2/5] leds: leds-st1202: initialize hardware before DT node child operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CWLP123MB547319E34D8A3A891D37DBBBC5FC2@CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM>
Date: Wed, 12 Feb 2025 15:15:13 +0000 (GMT)
From: Manuel Fombuena <fombuena@...look.com>
To: Lee Jones <lee@...nel.org>
cc: pavel@....cz, corbet@....net, linux-leds@...r.kernel.org, 
    linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 2/5] leds: leds-st1202: initialize hardware before
 DT node child operations

On Tue, 11 Feb 2025, Lee Jones wrote:

> On Sat, 01 Feb 2025, Manuel Fombuena wrote:
> 
> > Arguably, there are more chances of errors occurring during the
> > initialization of the hardware, so this should complete successfully
> > before the DT node childreen are initialized.
> 
> Okay.  And you're sure nothing in Setup needs the DT info?

Yes, st1202_setup() doesn't require anything previously done in  
st1202_dt_init() to do its thing.

Additionally, I am not just relying on reviewing the code. I am also 
carrying out real-world testing on a device I use daily and it works 
either way.

--
Manuel Fombuena