linux-kernel - RE: [PATCH] arm64: dts: socfpga: agilex5: fix gpio0 address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BL3PR11MB653289A0BDF5573776D2E519A2FC2@BL3PR11MB6532.namprd11.prod.outlook.com>
Date: Wed, 12 Feb 2025 16:03:53 +0000
From: "Rabara, Niravkumar L" <niravkumar.l.rabara@...el.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Dinh Nguyen <dinguyen@...nel.org>,
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, "nirav.rabara@...era.com"
	<nirav.rabara@...era.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH] arm64: dts: socfpga: agilex5: fix gpio0 address



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Wednesday, 12 February, 2025 11:32 PM
> To: Rabara, Niravkumar L <niravkumar.l.rabara@...el.com>; Dinh Nguyen
> <dinguyen@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>;
> nirav.rabara@...era.com; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: stable@...r.kernel.org
> Subject: Re: [PATCH] arm64: dts: socfpga: agilex5: fix gpio0 address
> 
> On 12/02/2025 11:01, niravkumar.l.rabara@...el.com wrote:
> > From: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
> >
> > Fix gpio0 controller address for Agilex5.
> 
> How do you fix it exactly?

gpio0 address is incorrect here.  
0xffc03200 address is for Agilex7 not for Agilex5.
0x10c03200 is correct address for Agilex5. 
 
I will update the commit message.
"Fix incorrect gpio0 address for Agilex5".  

> 
> >
> > Fixes: 3f7c869e143a ("arm64: dts: socfpga: agilex5: Add gpio0 node and
> > spi dma handshake id")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
> > ---
> >  arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > index 51c6e19e40b8..9e4ef24c8318 100644
> > --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > @@ -222,7 +222,7 @@ i3c1: i3c@...a1000 {
> >  			status = "disabled";
> >  		};
> >
> > -		gpio0: gpio@...03200 {
> > +		gpio0: gpio@...03200 {
> 
> I see now warning. Are you sure you tested it according to maintainer-soc-
> clean-dts profile?
> 

My bad, I have submitted incorrect patch. 
It supposes to have these changes, I will update in v2.  

-               gpio0: gpio@...03200 {
+               gpio0: gpio@...03200 {
                        compatible = "snps,dw-apb-gpio";
-                       reg = <0xffc03200 0x100>;
+                       reg = <0x10c03200 0x100>;

Thanks,
Nirav