| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202502121131.W1HsUg9j-lkp@intel.com>
Date: Wed, 12 Feb 2025 11:19:46 +0800
From: kernel test robot <lkp@...el.com>
To: patrice.chotard@...s.st.com, Mark Brown <broonie@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Arnd Bergmann <arnd@...db.de>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-spi@...r.kernel.org,
devicetree@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
christophe.kerello@...s.st.com, patrice.chotard@...s.st.com
Subject: Re: [PATCH v3 4/8] memory: Add STM32 Octo Memory Manager driver
Hi,
kernel test robot noticed the following build errors:
[auto build test ERROR on broonie-spi/for-next]
[also build test ERROR on atorgue-stm32/stm32-next krzk-mem-ctrl/for-next linus/master v6.14-rc2 next-20250210]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/patrice-chotard-foss-st-com/dt-bindings-spi-Add-STM32-OSPI-controller/20250210-212554
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link: https://lore.kernel.org/r/20250210131826.220318-5-patrice.chotard%40foss.st.com
patch subject: [PATCH v3 4/8] memory: Add STM32 Octo Memory Manager driver
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20250212/202502121131.W1HsUg9j-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250212/202502121131.W1HsUg9j-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502121131.W1HsUg9j-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/memory/stm32_omm.c:82:25: note: in expansion of macro 'dev_err'
82 | dev_err(dev, "[0x%llx-0x%llx] doesn't fit inside [0x%llx-0x%llx]\n",
| ^~~~~~~
drivers/memory/stm32_omm.c:82:80: note: format string is defined here
82 | dev_err(dev, "[0x%llx-0x%llx] doesn't fit inside [0x%llx-0x%llx]\n",
| ~~~^
| |
| long long unsigned int
| %x
drivers/memory/stm32_omm.c:82:38: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
82 | dev_err(dev, "[0x%llx-0x%llx] doesn't fit inside [0x%llx-0x%llx]\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/memory/stm32_omm.c:82:25: note: in expansion of macro 'dev_err'
82 | dev_err(dev, "[0x%llx-0x%llx] doesn't fit inside [0x%llx-0x%llx]\n",
| ^~~~~~~
drivers/memory/stm32_omm.c:82:87: note: format string is defined here
82 | dev_err(dev, "[0x%llx-0x%llx] doesn't fit inside [0x%llx-0x%llx]\n",
| ~~~^
| |
| long long unsigned int
| %x
drivers/memory/stm32_omm.c:96:46: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
96 | dev_err(dev, "[0x%llx-0x%llx] overlaps [0x%llx-0x%llx]\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/memory/stm32_omm.c:96:33: note: in expansion of macro 'dev_err'
96 | dev_err(dev, "[0x%llx-0x%llx] overlaps [0x%llx-0x%llx]\n",
| ^~~~~~~
drivers/memory/stm32_omm.c:96:53: note: format string is defined here
96 | dev_err(dev, "[0x%llx-0x%llx] overlaps [0x%llx-0x%llx]\n",
| ~~~^
| |
| long long unsigned int
| %x
drivers/memory/stm32_omm.c:96:46: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
96 | dev_err(dev, "[0x%llx-0x%llx] overlaps [0x%llx-0x%llx]\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/memory/stm32_omm.c:96:33: note: in expansion of macro 'dev_err'
96 | dev_err(dev, "[0x%llx-0x%llx] overlaps [0x%llx-0x%llx]\n",
| ^~~~~~~
drivers/memory/stm32_omm.c:96:60: note: format string is defined here
96 | dev_err(dev, "[0x%llx-0x%llx] overlaps [0x%llx-0x%llx]\n",
| ~~~^
| |
| long long unsigned int
| %x
drivers/memory/stm32_omm.c:96:46: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
96 | dev_err(dev, "[0x%llx-0x%llx] overlaps [0x%llx-0x%llx]\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/memory/stm32_omm.c:96:33: note: in expansion of macro 'dev_err'
96 | dev_err(dev, "[0x%llx-0x%llx] overlaps [0x%llx-0x%llx]\n",
| ^~~~~~~
drivers/memory/stm32_omm.c:96:78: note: format string is defined here
96 | dev_err(dev, "[0x%llx-0x%llx] overlaps [0x%llx-0x%llx]\n",
| ~~~^
| |
| long long unsigned int
| %x
drivers/memory/stm32_omm.c:96:46: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
96 | dev_err(dev, "[0x%llx-0x%llx] overlaps [0x%llx-0x%llx]\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/memory/stm32_omm.c:96:33: note: in expansion of macro 'dev_err'
96 | dev_err(dev, "[0x%llx-0x%llx] overlaps [0x%llx-0x%llx]\n",
| ^~~~~~~
drivers/memory/stm32_omm.c:96:85: note: format string is defined here
96 | dev_err(dev, "[0x%llx-0x%llx] overlaps [0x%llx-0x%llx]\n",
| ~~~^
| |
| long long unsigned int
| %x
drivers/memory/stm32_omm.c: In function 'stm32_omm_configure':
>> drivers/memory/stm32_omm.c:224:35: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
224 | req2ack = FIELD_PREP(CR_REQ2ACK_MASK, req2ack);
| ^~~~~~~~~~
vim +/FIELD_PREP +224 drivers/memory/stm32_omm.c
164
165 static int stm32_omm_configure(struct device *dev)
166 {
167 struct stm32_omm *omm = dev_get_drvdata(dev);
168 struct reset_control *rstc;
169 unsigned long clk_rate, clk_rate_max = 0;
170 int ret;
171 u8 i;
172 u32 mux = 0;
173 u32 cssel_ovr = 0;
174 u32 req2ack = 0;
175
176 omm->clk = devm_clk_get(dev, NULL);
177 if (IS_ERR(omm->clk)) {
178 dev_err(dev, "Failed to get OMM clock (%ld)\n",
179 PTR_ERR(omm->clk));
180
181 return PTR_ERR(omm->clk);
182 }
183
184 ret = pm_runtime_resume_and_get(dev);
185 if (ret < 0)
186 return ret;
187
188 /* parse children's clock */
189 for (i = 0; i < omm->nb_child; i++) {
190 clk_rate = clk_get_rate(omm->child[i].clk);
191 if (!clk_rate) {
192 dev_err(dev, "Invalid clock rate\n");
193 goto err_clk_disable;
194 }
195
196 if (clk_rate > clk_rate_max)
197 clk_rate_max = clk_rate;
198 }
199
200 rstc = devm_reset_control_get_optional_exclusive(dev, NULL);
201 if (IS_ERR(rstc)) {
202 ret = dev_err_probe(dev, PTR_ERR(rstc), "reset get failed\n");
203 goto err_clk_disable;
204 }
205
206 reset_control_assert(rstc);
207 udelay(2);
208 reset_control_deassert(rstc);
209
210 omm->cr = readl_relaxed(omm->io_base + OMM_CR);
211 /* optional */
212 ret = of_property_read_u32(dev->of_node, "st,omm-mux", &mux);
213 if (!ret) {
214 if (mux & CR_MUXEN) {
215 ret = of_property_read_u32(dev->of_node, "st,omm-req2ack-ns",
216 &req2ack);
217 if (!ret && !req2ack) {
218 req2ack = DIV_ROUND_UP(req2ack, NSEC_PER_SEC / clk_rate_max) - 1;
219
220 if (req2ack > 256)
221 req2ack = 256;
222 }
223
> 224 req2ack = FIELD_PREP(CR_REQ2ACK_MASK, req2ack);
225
226 omm->cr &= ~CR_REQ2ACK_MASK;
227 omm->cr |= FIELD_PREP(CR_REQ2ACK_MASK, req2ack);
228
229 /*
230 * If the mux is enabled, the 2 OSPI clocks have to be
231 * always enabled
232 */
233 ret = stm32_omm_enable_child_clock(dev, true);
234 if (ret)
235 goto err_clk_disable;
236 }
237
238 omm->cr &= ~CR_MUXENMODE_MASK;
239 omm->cr |= FIELD_PREP(CR_MUXENMODE_MASK, mux);
240 }
241
242 /* optional */
243 ret = of_property_read_u32(dev->of_node, "st,omm-cssel-ovr", &cssel_ovr);
244 if (!ret) {
245 omm->cr &= ~CR_CSSEL_OVR_MASK;
246 omm->cr |= FIELD_PREP(CR_CSSEL_OVR_MASK, cssel_ovr);
247 omm->cr |= CR_CSSEL_OVR_EN;
248 }
249
250 omm->restore_omm = true;
251 writel_relaxed(omm->cr, omm->io_base + OMM_CR);
252
253 ret = stm32_omm_set_amcr(dev, true);
254
255 err_clk_disable:
256 pm_runtime_put_sync_suspend(dev);
257
258 return ret;
259 }
260
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists