linux-kernel - Re: [PATCH 2/2] dt-bindings: memory-controllers: Add mediatek common-dramc dt-bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88cb93d2dcf9db1aad5e5641bda0cb9ba73875fa.camel@mediatek.com>
Date: Wed, 12 Feb 2025 03:21:06 +0000
From: Crystal Guo (郭晶) <Crystal.Guo@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"krzk@...nel.org" <krzk@...nel.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH 2/2] dt-bindings: memory-controllers: Add mediatek
 common-dramc dt-bindings

On Tue, 2025-02-11 at 16:57 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 11/02/2025 13:59, Crystal Guo (郭晶) wrote:
> > On Sun, 2025-02-09 at 11:52 +0100, Krzysztof Kozlowski wrote:
> > > External email : Please do not click links or open attachments
> > > until
> > > you have verified the sender or the content.
> > > 
> > > 
> > > On 08/02/2025 05:40, Crystal Guo (郭晶) wrote:
> > > > On Thu, 2024-12-12 at 11:58 +0100, Krzysztof Kozlowski wrote:
> > > > > External email : Please do not click links or open
> > > > > attachments
> > > > > until
> > > > > you have verified the sender or the content.
> > > > > 
> > > > > 
> > > > > On 12/12/2024 09:59, Crystal Guo wrote:
> > > > > > Add devicetree binding for mediatek common-dramc driver.
> > > > > > 
> > > > > > The DRAM controller of MediaTek SoC provides an interface
> > > > > > to
> > > > > > get the current data rate of DRAM.
> > > > > 
> > > > > Bindings are before users.
> > > 
> > > Do not ignore comments but implement them or keep discussing.
> > > 
> > > Best regards,
> > > Krzysztof
> > 
> > Got it, I have replied to the previous comments. Thanks for the
> > reminder.
> 
> 
> Ah, so these replies were because of this. Thanks, that makes sense,
> although still two months after initial review, so I am out of the
> context.
> 
> I assume above also means you implement the feedback :)
> 
> Best regards,
> Krzysztof

Yes, I have pushed the v2 patch based on these comments:
https://patchwork.kernel.org/project/linux-mediatek/list/?series=931410

Changes in v2:
- Remove pr_info and pr_err, use dev_err or dev_err_probe to print
  error message;
- Replace module_init by module_platform_driver;
- Remove unnecessary global variables;
- Change fmeter-verison to platform data;
- Remove mtk-dramc.h;
- Refine compatible to "mediatek,mt8196-dramc";
- Refine CONFIG name to MEDIATEK_MC;
- Fix yaml build errors, remove unnecessary properties on yaml file.

Please help review this new version, thanks.

Best regards
Crystal