linux-kernel - Re: [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch is modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6wxp7UE9MAht4pc@gondor.apana.org.au>
Date: Wed, 12 Feb 2025 13:29:11 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Eric Biggers <ebiggers@...nel.org>
Cc: kernel test robot <lkp@...el.com>, Danny Tsen <dtsen@...ux.ibm.com>,
	oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Ard Biesheuvel <ardb@...nel.org>,
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch
 is modular

On Wed, Feb 12, 2025 at 05:09:36AM +0000, Eric Biggers wrote:
>
> Please name these like ARCH_HAS_CURVE25519 and CRYPTO_LIB_CURVE25519_ARCH to be
> consistent with the CRC library, the many other ARCH_HAS_* options, and
> CRYPTO_LIB_CURVE25519_GENERIC.  Nothing uses names that contain "MAY_HAVE",
> which is ambiguous.
> 
> FWIW, at some point the arch optimized crypto algorithms also need to just be
> enabled by default.  The fact that they're not is a longstanding bug that is
> really harmful to users and needs to be fixed.

I'm simply responding to an lkp report.  While your suggestions
may have merit, I don't have the time to pursue them.

Feel free to send patches if you wish.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt