linux-kernel - Re: [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch is modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250212054428.GC2010357@google.com>
Date: Wed, 12 Feb 2025 05:44:28 +0000
From: Eric Biggers <ebiggers@...nel.org>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: kernel test robot <lkp@...el.com>, Danny Tsen <dtsen@...ux.ibm.com>,
	oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Ard Biesheuvel <ardb@...nel.org>,
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch
 is modular

On Wed, Feb 12, 2025 at 01:29:11PM +0800, Herbert Xu wrote:
> On Wed, Feb 12, 2025 at 05:09:36AM +0000, Eric Biggers wrote:
> >
> > Please name these like ARCH_HAS_CURVE25519 and CRYPTO_LIB_CURVE25519_ARCH to be
> > consistent with the CRC library, the many other ARCH_HAS_* options, and
> > CRYPTO_LIB_CURVE25519_GENERIC.  Nothing uses names that contain "MAY_HAVE",
> > which is ambiguous.
> > 
> > FWIW, at some point the arch optimized crypto algorithms also need to just be
> > enabled by default.  The fact that they're not is a longstanding bug that is
> > really harmful to users and needs to be fixed.
> 
> I'm simply responding to an lkp report.  While your suggestions
> may have merit, I don't have the time to pursue them.

The way that the arch options are selected is very much related to this issue,
but even disregarding that the first paragraph of my response is a review
comment directly on this patch about the naming it uses.

- Eric