linux-kernel - RE: [EXTERNAL] Re: [net-next PATCH v5 1/6] octeontx2-pf: use xdp_return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SJ0PR18MB5216D06F41966F59F06E6A0BDBFC2@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date: Wed, 12 Feb 2025 06:44:26 +0000
From: Suman Ghosh <sumang@...vell.com>
To: Simon Horman <horms@...nel.org>
CC: Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula
	<gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linu Cherian
	<lcherian@...vell.com>, Jerin Jacob <jerinj@...vell.com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        Bharat Bhushan
	<bbhushan2@...vell.com>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "ast@...nel.org"
	<ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "larysa.zaremba@...el.com"
	<larysa.zaremba@...el.com>
Subject: RE: [EXTERNAL] Re: [net-next PATCH v5 1/6] octeontx2-pf: use
 xdp_return_frame() to free xdp buffers

>>  static void otx2_xdp_snd_pkt_handler(struct otx2_nic *pfvf,
>>  				     struct otx2_snd_queue *sq,
>> -				 struct nix_cqe_tx_s *cqe)
>> +				     struct nix_cqe_tx_s *cqe)
>>  {
>>  	struct nix_send_comp_s *snd_comp = &cqe->comp;
>>  	struct sg_list *sg;
>>  	struct page *page;
>> -	u64 pa;
>> +	u64 pa, iova;
>>
>>  	sg = &sq->sg[snd_comp->sqe_id];
>>
>> -	pa = otx2_iova_to_phys(pfvf->iommu_domain, sg->dma_addr[0]);
>> -	otx2_dma_unmap_page(pfvf, sg->dma_addr[0],
>> -			    sg->size[0], DMA_TO_DEVICE);
>> +	iova = sg->dma_addr[0];
>> +	pa = otx2_iova_to_phys(pfvf->iommu_domain, iova);
>>  	page = virt_to_page(phys_to_virt(pa));
>> -	put_page(page);
>
>Hi Suman,
>
>With this patch applied page is assigned but otherwise unused in this
>function. So unless there are some side effects of the above, I think
>page and in turn pa and iova can be removed.
[Suman] ack, will update in v6
>
>> +	if (sg->flags & XDP_REDIRECT)
>> +		otx2_dma_unmap_page(pfvf, sg->dma_addr[0], sg->size[0],
>DMA_TO_DEVICE);
>> +	xdp_return_frame((struct xdp_frame *)sg->skb);
>> +	sg->skb = (u64)NULL;
>>  }
>>
>>  static void otx2_snd_pkt_handler(struct otx2_nic *pfvf,
>
>...