[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<SJ0PR18MB52165A2B9D6A396C3946EE29DBFC2@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date: Wed, 12 Feb 2025 06:45:16 +0000
From: Suman Ghosh <sumang@...vell.com>
To: Simon Horman <horms@...nel.org>
CC: Sunil Kovvuri Goutham <sgoutham@...vell.com>,
Geethasowjanya Akula
<gakula@...vell.com>,
Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
Hariprasad Kelam <hkelam@...vell.com>,
"davem@...emloft.net"
<davem@...emloft.net>,
"edumazet@...gle.com" <edumazet@...gle.com>,
"kuba@...nel.org" <kuba@...nel.org>,
"pabeni@...hat.com" <pabeni@...hat.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Linu Cherian
<lcherian@...vell.com>, Jerin Jacob <jerinj@...vell.com>,
"john.fastabend@...il.com" <john.fastabend@...il.com>,
Bharat Bhushan
<bbhushan2@...vell.com>,
"hawk@...nel.org" <hawk@...nel.org>,
"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
"ast@...nel.org"
<ast@...nel.org>,
"daniel@...earbox.net" <daniel@...earbox.net>,
"bpf@...r.kernel.org" <bpf@...r.kernel.org>,
"larysa.zaremba@...el.com"
<larysa.zaremba@...el.com>
Subject: RE: [EXTERNAL] Re: [net-next PATCH v5 1/6] octeontx2-pf: use
xdp_return_frame() to free xdp buffers
>> > - u64 pa;
>> > + u64 pa, iova;
>> >
>> > sg = &sq->sg[snd_comp->sqe_id];
>> >
>> > - pa = otx2_iova_to_phys(pfvf->iommu_domain, sg->dma_addr[0]);
>> > - otx2_dma_unmap_page(pfvf, sg->dma_addr[0],
>> > - sg->size[0], DMA_TO_DEVICE);
>> > + iova = sg->dma_addr[0];
>> > + pa = otx2_iova_to_phys(pfvf->iommu_domain, iova);
>> > page = virt_to_page(phys_to_virt(pa));
>> > - put_page(page);
>>
>> Hi Suman,
>>
>> With this patch applied page is assigned but otherwise unused in this
>> function. So unless there are some side effects of the above, I think
>> page and in turn pa and iova can be removed.
>
>I now see that page and pa are removed in patch 6/6, although iova is
>left behind. I think it would be best to move the cleanup forward to
>this patch.
[Suman] ack, will update in v6
Powered by blists - more mailing lists