linux-kernel - RE: [EXTERNAL] Re: [net-next PATCH v5 1/6] octeontx2-pf: use xdp_return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SJ0PR18MB521689E55D82269FF7416E3ADBFC2@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date: Wed, 12 Feb 2025 06:52:41 +0000
From: Suman Ghosh <sumang@...vell.com>
To: Simon Horman <horms@...nel.org>
CC: Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula
	<gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linu Cherian
	<lcherian@...vell.com>, Jerin Jacob <jerinj@...vell.com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        Bharat Bhushan
	<bbhushan2@...vell.com>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "ast@...nel.org"
	<ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "larysa.zaremba@...el.com"
	<larysa.zaremba@...el.com>
Subject: RE: [EXTERNAL] Re: [net-next PATCH v5 1/6] octeontx2-pf: use
 xdp_return_frame() to free xdp buffers

>> @@ -1465,10 +1476,14 @@ static bool otx2_xdp_rcv_pkt_handler(struct
>otx2_nic *pfvf,
>>  		trace_xdp_exception(pfvf->netdev, prog, act);
>>  		break;
>>  	case XDP_DROP:
>> +		cq->pool_ptrs++;
>> +		if (page->pp) {
>> +			page_pool_recycle_direct(pool->page_pool, page);
>> +			return true;
>> +		}
>>  		otx2_dma_unmap_page(pfvf, iova, pfvf->rbsize,
>>  				    DMA_FROM_DEVICE);
>>  		put_page(page);
>> -		cq->pool_ptrs++;
>>  		return true;
>
>The above seems to get shuffled around in the next patch anyway, so
>maybe it's best to do this here (completely untested):
>
>	case XDP_DROP:
>		cq->pool_ptrs++;
>		if (page->pp) {
>			page_pool_recycle_direct(pool->page_pool, page);
>		} else {
>			otx2_dma_unmap_page(pfvf, iova, pfvf->rbsize,
>					    DMA_FROM_DEVICE);
>			put_page(page);
>		}
>		return true;
>
>>  	}
>>  	return false;
[Suman] ack, will update in v6
>
>...