linux-kernel - Re: [PATCH v2 2/5] drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3572b4b0-5d32-4331-b241-567701c2cf7b@redhat.com>
Date: Wed, 12 Feb 2025 11:47:46 +0100
From: Hans de Goede <hdegoede@...hat.com>
To: John Edwards <uejji@...ji.net>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Thomas Zimmermann <tzimmermann@...e.de>
Cc: Andrew Wyatt <fewtarius@...amfork.org>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, Paco Avelar <pacoavelar@...mail.com>
Subject: Re: [PATCH v2 2/5] drm: panel-orientation-quirks: Add quirks for AYA
 NEO Flip DS and KB

Hi,

Thank you for your patches and sorry for being slow to respond.

On 24-Jan-25 9:46 PM, John Edwards wrote:
> From: Andrew Wyatt <fewtarius@...amfork.org>
> 
> The AYA NEO Flip DS and KB both use a 1080x1920 portrait LCD panel.  The
> Flip DS additionally uses a 640x960 portrait LCD panel as a second display.
> 
> Add DMI matches to correctly rotate these panels.
> 
> Signed-off-by: Andrew Wyatt <fewtarius@...amfork.org>
> Co-developed-by: John Edwards <uejji@...ji.net>
> Signed-off-by: John Edwards <uejji@...ji.net>
> Tested-by: Paco Avelar <pacoavelar@...mail.com>
> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index f9c975338..c5acf2628 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -93,6 +93,12 @@ static const struct drm_dmi_panel_orientation_data onegx1_pro = {
>  	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
>  };
>  
> +static const struct drm_dmi_panel_orientation_data lcd640x960_leftside_up = {
> +	.width = 640,
> +	.height = 960,
> +	.orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
> +};
> +
>  static const struct drm_dmi_panel_orientation_data lcd720x1280_rightside_up = {
>  	.width = 720,
>  	.height = 1280,
> @@ -202,6 +208,18 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_MATCH(DMI_PRODUCT_NAME, "AIR"),
>  		},
>  		.driver_data = (void *)&lcd1080x1920_leftside_up,
> +	}, {    /* AYA NEO Flip DS Bottom Screen */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "FLIP DS"),
> +	},

Since this '}' is closing the .matches initializer it should be indented 2 tabs,
note I think we can fix this up while merging things so no need for a v3
(assuming Thomas agrees).

> +		.driver_data = (void *)&lcd640x960_leftside_up,
> +	}, {    /* AYA NEO Flip KB/DS Top Screen */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> +		  DMI_MATCH(DMI_PRODUCT_NAME, "FLIP"),
> +	},

Since this '}' is closing the .matches initializer it should be indented 2 tabs

> +		.driver_data = (void *)&lcd1080x1920_leftside_up,
>  	}, {	/* AYA NEO Founder */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYA NEO"),

Regards,

Hans