linux-kernel - Re: [PATCH v2 3/5] drm: panel-orientation-quirks: Add quirk for AYA NEO Slide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eec5bb5f-80ad-469e-b3bc-1e8bb2de36a2@redhat.com>
Date: Wed, 12 Feb 2025 11:48:01 +0100
From: Hans de Goede <hdegoede@...hat.com>
To: John Edwards <uejji@...ji.net>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: Andrew Wyatt <fewtarius@...amfork.org>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] drm: panel-orientation-quirks: Add quirk for AYA
 NEO Slide

Hi,

On 24-Jan-25 9:46 PM, John Edwards wrote:
> From: Andrew Wyatt <fewtarius@...amfork.org>
> 
> The AYANEO Slide uses a 1080x1920 portrait LCD panel.  This is the same
> panel used on the AYANEO Air Plus, but the DMI data is too different to
> match both with one entry.
> 
> Add a DMI match to correctly rotate the panel on the AYANEO Slide.
> 
> This also covers the Antec Core HS, which is a rebranded AYANEO Slide with
> the exact same hardware and DMI strings.
> 
> Signed-off-by: Andrew Wyatt <fewtarius@...amfork.org>
> Signed-off-by: John Edwards <uejji@...ji.net>
> Tested-by: John Edwards <uejji@...ji.net>
> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index c5acf2628..9e6708cd1 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -244,6 +244,12 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_MATCH(DMI_BOARD_NAME, "KUN"),
>  		},
>  		.driver_data = (void *)&lcd1600x2560_rightside_up,
> +	}, {	/* AYA NEO SLIDE */
> +		 .matches = {
> +		   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> +		   DMI_MATCH(DMI_PRODUCT_NAME, "SLIDE"),
> +	},

Since this '}' is closing the .matches initializer it should be indented 2 tabs

> +		.driver_data = (void *)&lcd1080x1920_leftside_up,
>  	}, {    /* AYN Loki Max */
>  		.matches = {
>  			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ayn"),

Regards,

Hans