linux-kernel - Re: [PATCH v5 1/2] hwmon: add GPD devices sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502140302.IkW9UALU-lkp@intel.com>
Date: Fri, 14 Feb 2025 03:32:05 +0800
From: kernel test robot <lkp@...el.com>
To: Cryolitia PukNgae via B4 Relay <devnull+Cryolitia.gmail.com@...nel.org>,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Cryolitia PukNgae <Cryolitia@...il.com>,
	Jonathan Corbet <corbet@....net>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
	linux-doc@...r.kernel.org, Celeste Liu <CoelacanthusHex@...il.com>,
	Yao Zi <ziyao@...root.org>,
	Derek John Clark <derekjohn.clark@...il.com>,
	Marcin Strągowski <marcin@...agowski.com>,
	someone5678 <someone5678.dev@...il.com>,
	Justin Weiss <justin@...tinweiss.com>
Subject: Re: [PATCH v5 1/2] hwmon: add GPD devices sensor driver

Hi Cryolitia,

kernel test robot noticed the following build warnings:

[auto build test WARNING on ffd294d346d185b70e28b1a28abe367bbfe53c04]

url:    https://github.com/intel-lab-lkp/linux/commits/Cryolitia-PukNgae-via-B4-Relay/hwmon-add-GPD-devices-sensor-driver/20250211-150418
base:   ffd294d346d185b70e28b1a28abe367bbfe53c04
patch link:    https://lore.kernel.org/r/20250211-gpd_fan-v5-1-608f4255f0e1%40gmail.com
patch subject: [PATCH v5 1/2] hwmon: add GPD devices sensor driver
config: i386-randconfig-002-20250214 (https://download.01.org/0day-ci/archive/20250214/202502140302.IkW9UALU-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250214/202502140302.IkW9UALU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502140302.IkW9UALU-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/hwmon/gpd-fan.c:361:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
     361 |                 const struct gpd_board_drvdata *drvdata = gpd_driver_priv.drvdata;
         |                 ^
   drivers/hwmon/gpd-fan.c:452:4: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
     452 |                         int ret = gpd_read_pwm();
         |                         ^
   drivers/hwmon/gpd-fan.c:478:4: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
     478 |                         u8 var = clamp_val(val, 0, 255);
         |                         ^
   3 warnings generated.


vim +361 drivers/hwmon/gpd-fan.c

   352	
   353	static int gpd_win_mini_set_pwm_enable(enum FAN_PWM_ENABLE pwm_enable)
   354	{
   355		switch (pwm_enable) {
   356		case DISABLE:
   357			return gpd_generic_write_pwm(255);
   358		case MANUAL:
   359			return gpd_generic_write_pwm(gpd_driver_priv.pwm_value);
   360		case AUTOMATIC:
 > 361			const struct gpd_board_drvdata *drvdata = gpd_driver_priv.drvdata;
   362	
   363			return gpd_ecram_write(drvdata, drvdata->pwm_write, 0);
   364		}
   365		return 0;
   366	}
   367	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki