linux-kernel - Re: [RFC PATCH v5 0/7] mseal system mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CD0870ED-6857-45EF-9C28-F27475964D71@kernel.org>
Date: Thu, 13 Feb 2025 11:34:07 -0800
From: Kees Cook <kees@...nel.org>
To: "Liam R. Howlett" <Liam.Howlett@...cle.com>
CC: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, jeffxu@...omium.org,
 akpm@...ux-foundation.org, jannh@...gle.com, torvalds@...ux-foundation.org,
 vbabka@...e.cz, adhemerval.zanella@...aro.org, oleg@...hat.com,
 avagin@...il.com, benjamin@...solutions.net, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org, linux-mm@...ck.org, jorgelo@...omium.org,
 sroettger@...gle.com, hch@....de, ojeda@...nel.org,
 thomas.weissschuh@...utronix.de, adobriyan@...il.com,
 johannes@...solutions.net, pedro.falcato@...il.com, hca@...ux.ibm.com,
 willy@...radead.org, anna-maria@...utronix.de, mark.rutland@....com,
 linus.walleij@...aro.org, Jason@...c4.com, deller@....de,
 rdunlap@...radead.org, davem@...emloft.net, peterx@...hat.com,
 f.fainelli@...il.com, gerg@...nel.org, dave.hansen@...ux.intel.com,
 mingo@...nel.org, ardb@...nel.org, mhocko@...e.com, 42.hyeyoo@...il.com,
 peterz@...radead.org, ardb@...gle.com, enh@...gle.com, rientjes@...gle.com,
 groeck@...omium.org, mpe@...erman.id.au, aleksandr.mikhalitsyn@...onical.com,
 mike.rapoport@...il.com
Subject: Re: [RFC PATCH v5 0/7] mseal system mappings

On February 13, 2025 10:35:21 AM PST, "Liam R. Howlett" <Liam.Howlett@...cle.com> wrote:
>* Kees Cook <kees@...nel.org> [250212 17:05]:
>> On Wed, Feb 12, 2025 at 11:24:35AM +0000, Lorenzo Stoakes wrote:
>> > On Wed, Feb 12, 2025 at 03:21:48AM +0000, jeffxu@...omium.org wrote:
>> > > From: Jeff Xu <jeffxu@...omium.org>
>> > >
>> > > The commit message in the first patch contains the full description of
>> > > this series.
>> > 
>> > Sorry to nit, but it'd be useful to reproduce in the cover letter too! But
>> > this obviously isn't urgent, just be nice when we un-RFC.
>> 
>> I advised Jeff against this because I've found it can sometimes cause
>> "thread splitting" in that some people reply to the cover letter, and
>> some people reply to the first patch, etc. I've tended to try to keep
>> cover letters very general, with the bulk of the prose in the first
>> patch.
>
>Interesting idea, but I think thread splitting is less of a concern than
>diluting the meaning of a patch by including a lengthy change log with a
>fraction of the text being about the code that follows.
>
>I think this is the reason for a cover letter in the first place; not
>just version control.  After all, we could tack the version information
>into the first patch too and avoid it being in the final commit message.

Okay, so to be clear: you'd prefer to put the rationales and other stuff in the cover, and put more specific details in the first patch? I've not liked this because cover letters aren't (except for akpm's trees) included anywhere in git, which makes archeology much harder.

-Kees

-- 
Kees Cook