linux-kernel - Re: [PATCH next] ice, irdma: fix an off by one in error handling code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z62HZM0xjSWSSBiL@mev-dev.igk.intel.com>
Date: Thu, 13 Feb 2025 06:47:16 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	Mustafa Ismail <mustafa.ismail@...el.com>,
	Tatyana Nikolova <tatyana.e.nikolova@...el.com>,
	Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>,
	Tony Nguyen <anthony.l.nguyen@...el.com>,
	Jacob Keller <jacob.e.keller@...el.com>, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] ice, irdma: fix an off by one in error handling code

On Wed, Feb 12, 2025 at 06:25:44PM +0300, Dan Carpenter wrote:
> If we don't allocate the MIN number of IRQs then we need to free what
> we have and return -ENOMEM.  The problem is this loop is off by one
> so it frees an entry that wasn't allocated and it doesn't free the
> first entry where i == 0.
> 
> Fixes: 3e0d3cb3fbe0 ("ice, irdma: move interrupts code to irdma")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/infiniband/hw/irdma/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/main.c b/drivers/infiniband/hw/irdma/main.c
> index 1ee8969595d3..5fc081ca8905 100644
> --- a/drivers/infiniband/hw/irdma/main.c
> +++ b/drivers/infiniband/hw/irdma/main.c
> @@ -221,7 +221,7 @@ static int irdma_init_interrupts(struct irdma_pci_f *rf, struct ice_pf *pf)
>  			break;
>  
>  	if (i < IRDMA_MIN_MSIX) {
> -		for (; i > 0; i--)
> +		while (--i >= 0)
>  			ice_free_rdma_qvector(pf, &rf->msix_entries[i]);
>  
>  		kfree(rf->msix_entries);

Przemek pointed that in the review, but somehow I missed that :( .
Thanks for fixing:
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

> -- 
> 2.47.2
>