linux-kernel - Re: [PATCH next] ice, irdma: fix an off by one in error handling code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d4c9bcb6-8440-43cf-85a9-ed46e087d769@intel.com>
Date: Fri, 14 Feb 2025 11:47:37 -0800
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>
CC: Mustafa Ismail <mustafa.ismail@...el.com>, Tatyana Nikolova
	<tatyana.e.nikolova@...el.com>, Jason Gunthorpe <jgg@...pe.ca>, "Leon
 Romanovsky" <leon@...nel.org>, Jacob Keller <jacob.e.keller@...el.com>,
	<linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH next] ice, irdma: fix an off by one in error handling code



On 2/12/2025 7:25 AM, Dan Carpenter wrote:
> If we don't allocate the MIN number of IRQs then we need to free what
> we have and return -ENOMEM.  The problem is this loop is off by one
> so it frees an entry that wasn't allocated and it doesn't free the
> first entry where i == 0.
> 
> Fixes: 3e0d3cb3fbe0 ("ice, irdma: move interrupts code to irdma")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Thanks for the patch Dan. I've applied this to iwl-next since it 
originated from there and I'd like to bundle this with the other fixes 
related to the series.

Thanks,
Tony

> ---
>   drivers/infiniband/hw/irdma/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/main.c b/drivers/infiniband/hw/irdma/main.c
> index 1ee8969595d3..5fc081ca8905 100644
> --- a/drivers/infiniband/hw/irdma/main.c
> +++ b/drivers/infiniband/hw/irdma/main.c
> @@ -221,7 +221,7 @@ static int irdma_init_interrupts(struct irdma_pci_f *rf, struct ice_pf *pf)
>   			break;
>   
>   	if (i < IRDMA_MIN_MSIX) {
> -		for (; i > 0; i--)
> +		while (--i >= 0)
>   			ice_free_rdma_qvector(pf, &rf->msix_entries[i]);
>   
>   		kfree(rf->msix_entries);