linux-kernel - Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed6a0be1-f7c3-4ada-9413-730c85a5cd3c@quicinc.com>
Date: Thu, 13 Feb 2025 13:59:57 +0800
From: Cheng Jiang <quic_chejiang@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_jiaymao@...cinc.com>,
        <quic_shuaz@...cinc.com>, <quic_zijuhu@...cinc.com>,
        <quic_mohamull@...cinc.com>
Subject: Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on
 qcs8300-ride

Hi Konrad,

On 2/11/2025 10:34 PM, Konrad Dybcio wrote:
> On 11.02.2025 11:44 AM, Cheng Jiang wrote:
>> Enable BT on qcs8300-ride by adding a node for the BT module. Since the
>> platform uses the QCA6698 Bluetooth chip. While the QCA6698 shares th
>> same IP core as the WCN6855, it has different RF components and RAM sizes,
>> requiring new firmware files. Use the firmware-name property to specify
>> the NVM and rampatch firmware to load.
>>
>> Signed-off-by: Cheng Jiang <quic_chejiang@...cinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 24 +++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> index a6991e8e2df6..93458773b72d 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> @@ -17,6 +17,7 @@ / {
>>  
>>  	aliases {
>>  		serial0 = &uart7;
>> +		serial1 = &uart2;
>>  	};
>>  
>>  	chosen {
>> @@ -451,6 +452,13 @@ &serdes0 {
>>  };
>>  
>>  &tlmm {
>> +	bt_en_state: bt-en-state {
>> +		pins = "gpio55";
>> +		function = "normal";
>> +		output-low;
>> +		bias-pull-down;
>> +	};
>> +
>>  	ethernet0_default: ethernet0-default-state {
>>  		ethernet0_mdc: ethernet0-mdc-pins {
>>  			pins = "gpio5";
>> @@ -544,6 +552,22 @@ wlan_en_state: wlan-en-state {
>>  	};
>>  };
>>  
>> +&uart2 {
>> +	status = "okay";
>> +	bluetooth: bluetooth {
> 
> Please add a newline between the last property and subnodes
> 
Ack.
>> +		compatible = "qcom,wcn6855-bt";
>> +		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
>> +
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&bt_en_state>;
> 
> You should use qcom,wcn6855-pmu (see e.g. sc8280xp-crd.dts)
> 
Ack. Will use the power sequence for BT power control. 
>> +		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
>> +
>> +		vddio-supply       = <&vreg_conn_pa>;         /* bt-vdd-ctrl1-supply */
>> +		vddbtcxmx-supply   = <&vreg_conn_1p8>;        /* bt-vdd-ctrl2-supply */
> 
> Drop these comments
> 
Ack.