linux-kernel - Re: [PATCH v3 1/2] dt-bindings: usb: Add binding for ChromeOS Pogo pin keyboard connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250213-amigurumi-shrew-of-grandeur-bb1a13@krzk-bin>
Date: Thu, 13 Feb 2025 09:11:25 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stephen Boyd <swboyd@...omium.org>
Cc: Konrad Dybcio <konradybcio@...nel.org>, 
	Bjorn Andersson <andersson@...nel.org>, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	patches@...ts.linux.dev, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Benson Leung <bleung@...omium.org>, devicetree@...r.kernel.org, chrome-platform@...ts.linux.dev, 
	Pin-yen Lin <treapking@...omium.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: usb: Add binding for ChromeOS Pogo
 pin keyboard connector

On Mon, Feb 10, 2025 at 02:57:11PM -0800, Stephen Boyd wrote:
> +$id: http://devicetree.org/schemas/usb/google,usb-pogo-keyboard.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Google USB Pogo Pin Keyboard
> +
> +maintainers:
> +  - Stephen Boyd <swboyd@...omium.org>
> +
> +description:
> +  ChromeOS devices with a detachable keyboard have a set of five pogo pins that
> +  are the typical four pins for USB (D+/D-, VBUS, GND) and an extra pin for
> +  base detection. The detachable keyboard is a USB device that connects to the
> +  four USB pogo pins.
> +
> +properties:
> +  compatible:
> +    const: google,usb-pogo-keyboard
> +
> +  '#address-cells':

If there is going to be any new version: please use consistent quotes,
either ' or "

> +    const: 1
> +
> +  '#size-cells':
> +    const: 0
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/properties/port
> +    description: Connection to USB2 port providing USB HS signals
> +    required:
> +      - endpoint
> +
> +patternProperties:
> +  "^keyboard@[0-9a-f]{1,2}$":

What does the unit address represent here? Why this isn't just
"keyboard"? One connector usually has only one keyboard, right?

Maybe it is only to fulfill the usb-device schema? The reg is there to
represent USB hub or controller port, which is not true here.

I don't have any idea how to solve it. I assume you need the keyboard
child, right?

Best regards,
Krzysztof