linux-kernel - Re: [PATCH 1/6] irqchip/renesas-rzg2l: Use local dev pointer in rzg2l_irqc_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8uPQxraOnVnafO-Ovk=inrzJWG+ySK5uO2uBOuXEDx+tA@mail.gmail.com>
Date: Thu, 13 Feb 2025 09:37:38 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, linux-kernel@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 1/6] irqchip/renesas-rzg2l: Use local dev pointer in rzg2l_irqc_common_init()

On Wed, Feb 12, 2025 at 6:22 PM Fabrizio Castro
<fabrizio.castro.jz@...esas.com> wrote:
>
> Replace direct references to `&pdev->dev` with the local `dev` pointer
> in rzg2l_irqc_common_init() to avoid redundant dereferencing.
>
> Suggested-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> ---
> Hi Geert,
>
> I have taken the liberty of adding your Suggested-by, I hope that's
> okay?
>
> I have also added a few more patches to further tidy up
> rzg2l_irqc_common_init().
>
> Thanks!
>
> Fab
> ---
>  drivers/irqchip/irq-renesas-rzg2l.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c
> index 99e27e01b0b1..a7c3a3cc6b9f 100644
> --- a/drivers/irqchip/irq-renesas-rzg2l.c
> +++ b/drivers/irqchip/irq-renesas-rzg2l.c
> @@ -542,40 +542,40 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
>
>         parent_domain = irq_find_host(parent);
>         if (!parent_domain) {
> -               dev_err(&pdev->dev, "cannot find parent domain\n");
> +               dev_err(dev, "cannot find parent domain\n");
>                 return -ENODEV;
>         }
>
> -       rzg2l_irqc_data = devm_kzalloc(&pdev->dev, sizeof(*rzg2l_irqc_data), GFP_KERNEL);
> +       rzg2l_irqc_data = devm_kzalloc(dev, sizeof(*rzg2l_irqc_data), GFP_KERNEL);
>         if (!rzg2l_irqc_data)
>                 return -ENOMEM;
>
>         rzg2l_irqc_data->irqchip = irq_chip;
>
> -       rzg2l_irqc_data->base = devm_of_iomap(&pdev->dev, pdev->dev.of_node, 0, NULL);
> +       rzg2l_irqc_data->base = devm_of_iomap(dev, dev->of_node, 0, NULL);
>         if (IS_ERR(rzg2l_irqc_data->base))
>                 return PTR_ERR(rzg2l_irqc_data->base);
>
>         ret = rzg2l_irqc_parse_interrupts(rzg2l_irqc_data, node);
>         if (ret) {
> -               dev_err(&pdev->dev, "cannot parse interrupts: %d\n", ret);
> +               dev_err(dev, "cannot parse interrupts: %d\n", ret);
>                 return ret;
>         }
>
> -       resetn = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> +       resetn = devm_reset_control_get_exclusive(dev, NULL);
>         if (IS_ERR(resetn))
>                 return PTR_ERR(resetn);
>
>         ret = reset_control_deassert(resetn);
>         if (ret) {
> -               dev_err(&pdev->dev, "failed to deassert resetn pin, %d\n", ret);
> +               dev_err(dev, "failed to deassert resetn pin, %d\n", ret);
>                 return ret;
>         }
>
> -       pm_runtime_enable(&pdev->dev);
> -       ret = pm_runtime_resume_and_get(&pdev->dev);
> +       pm_runtime_enable(dev);
> +       ret = pm_runtime_resume_and_get(dev);
>         if (ret < 0) {
> -               dev_err(&pdev->dev, "pm_runtime_resume_and_get failed: %d\n", ret);
> +               dev_err(dev, "pm_runtime_resume_and_get failed: %d\n", ret);
>                 goto pm_disable;
>         }
>
> @@ -585,7 +585,7 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
>                                               node, &rzg2l_irqc_domain_ops,
>                                               rzg2l_irqc_data);
>         if (!irq_domain) {
> -               dev_err(&pdev->dev, "failed to add irq domain\n");
> +               dev_err(dev, "failed to add irq domain\n");
>                 ret = -ENOMEM;
>                 goto pm_put;
>         }
> @@ -606,9 +606,9 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
>         return 0;
>
>  pm_put:
> -       pm_runtime_put(&pdev->dev);
> +       pm_runtime_put(dev);
>  pm_disable:
> -       pm_runtime_disable(&pdev->dev);
> +       pm_runtime_disable(dev);
>         reset_control_assert(resetn);
>         return ret;
>  }
> --
> 2.34.1
>
>