linux-kernel - Re: [PATCH 2/6] irqchip/renesas-rzg2l: Use devm_reset_control_get_exclusive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8vrnrrb2LsWQqW=WhdgMRYgZmExFME3bt-L92aFAv1Gug@mail.gmail.com>
Date: Thu, 13 Feb 2025 09:38:21 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, linux-kernel@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 2/6] irqchip/renesas-rzg2l: Use devm_reset_control_get_exclusive_deasserted()

On Wed, Feb 12, 2025 at 6:32 PM Fabrizio Castro
<fabrizio.castro.jz@...esas.com> wrote:
>
> Use devm_reset_control_get_exclusive_deasserted() to simplify
> rzg2l_irqc_common_init().
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> ---
>  drivers/irqchip/irq-renesas-rzg2l.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c
> index a7c3a3cc6b9f..a29c40466137 100644
> --- a/drivers/irqchip/irq-renesas-rzg2l.c
> +++ b/drivers/irqchip/irq-renesas-rzg2l.c
> @@ -562,14 +562,10 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
>                 return ret;
>         }
>
> -       resetn = devm_reset_control_get_exclusive(dev, NULL);
> -       if (IS_ERR(resetn))
> +       resetn = devm_reset_control_get_exclusive_deasserted(dev, NULL);
> +       if (IS_ERR(resetn)) {
> +               dev_err(dev, "failed to acquire deasserted reset: %d\n", ret);
>                 return PTR_ERR(resetn);
> -
> -       ret = reset_control_deassert(resetn);
> -       if (ret) {
> -               dev_err(dev, "failed to deassert resetn pin, %d\n", ret);
> -               return ret;
>         }
>
>         pm_runtime_enable(dev);
> @@ -609,7 +605,6 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
>         pm_runtime_put(dev);
>  pm_disable:
>         pm_runtime_disable(dev);
> -       reset_control_assert(resetn);
>         return ret;
>  }
>
> --
> 2.34.1
>
>