linux-kernel - Re: [PATCH 4/6] irqchip/renesas-rzg2l: Remove pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8vV1omcm3ASq00KQVPj8Aj06fczmYqkUDu2Dte1YbVsuQ@mail.gmail.com>
Date: Thu, 13 Feb 2025 09:41:03 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 4/6] irqchip/renesas-rzg2l: Remove pm_put label

On Wed, Feb 12, 2025 at 6:22 PM Fabrizio Castro
<fabrizio.castro.jz@...esas.com> wrote:
>
> No need to keep label `pm_put`, as it's only used once.
> Call pm_runtime_put() directly from the error path.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> ---
>  drivers/irqchip/irq-renesas-rzg2l.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c
> index c024023a1832..0f325ceb0f53 100644
> --- a/drivers/irqchip/irq-renesas-rzg2l.c
> +++ b/drivers/irqchip/irq-renesas-rzg2l.c
> @@ -586,9 +586,9 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
>                                               node, &rzg2l_irqc_domain_ops,
>                                               rzg2l_irqc_data);
>         if (!irq_domain) {
> +               pm_runtime_put(dev);
>                 dev_err(dev, "failed to add irq domain\n");
> -               ret = -ENOMEM;
> -               goto pm_put;
> +               return -ENOMEM;
>         }
>
>         register_syscore_ops(&rzg2l_irqc_syscore_ops);
> @@ -605,11 +605,6 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
>         dev = NULL;
>
>         return 0;
> -
> -pm_put:
> -       pm_runtime_put(dev);
> -
> -       return ret;
>  }
>
>  static int __init rzg2l_irqc_init(struct device_node *node,
> --
> 2.34.1
>
>