lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2025021323-opponent-strategic-a27f@gregkh>
Date: Thu, 13 Feb 2025 12:56:10 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: André Draszik <andre.draszik@...aro.org>
Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Peter Griffin <peter.griffin@...aro.org>,
	Tudor Ambarus <tudor.ambarus@...aro.org>,
	Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm/tcpci_maxim: better interrupt name

On Thu, Feb 13, 2025 at 11:44:59AM +0000, André Draszik wrote:
> Hi Greg,
> 
> On Thu, 2025-02-13 at 11:11 +0100, Greg Kroah-Hartman wrote:
> > On Thu, Feb 13, 2025 at 09:37:54AM +0000, André Draszik wrote:
> > > This changes the output of /proc/interrupts from the non-descriptive:
> > >     1-0025
> > > (or similar) to a more descriptive:
> > >     1-0025-max33359
> > > 
> > > This makes it easier to find the device, in particular if there are
> > > multiple i2c devices, as one doesn't have to remember (or lookup) where
> > > it is located.
> > > 
> > > Signed-off-by: André Draszik <andre.draszik@...aro.org>
> > > ---
> > >  drivers/usb/typec/tcpm/tcpci_maxim_core.c | 13 ++++++++++---
> > >  1 file changed, 10 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/usb/typec/tcpm/tcpci_maxim_core.c b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> > > index fd1b80593367..46fc626589db 100644
> > > --- a/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> > > +++ b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> > > @@ -420,12 +420,14 @@ static irqreturn_t max_tcpci_isr(int irq, void *dev_id)
> > >  	return IRQ_WAKE_THREAD;
> > >  }
> > >  
> > > -static int max_tcpci_init_alert(struct max_tcpci_chip *chip, struct i2c_client *client)
> > > +static int max_tcpci_init_alert(struct max_tcpci_chip *chip,
> > > +				struct i2c_client *client,
> > > +				const char *name)
> > >  {
> > >  	int ret;
> > >  
> > >  	ret = devm_request_threaded_irq(chip->dev, client->irq, max_tcpci_isr, max_tcpci_irq,
> > > -					(IRQF_TRIGGER_LOW | IRQF_ONESHOT), dev_name(chip->dev),
> > > +					(IRQF_TRIGGER_LOW | IRQF_ONESHOT), name,
> > >  					chip);
> > >  
> > >  	if (ret < 0)
> > > @@ -485,6 +487,7 @@ static int max_tcpci_probe(struct i2c_client *client)
> > >  	int ret;
> > >  	struct max_tcpci_chip *chip;
> > >  	u8 power_status;
> > > +	const char *name;
> > >  
> > >  	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
> > >  	if (!chip)
> > > @@ -531,7 +534,11 @@ static int max_tcpci_probe(struct i2c_client *client)
> > >  
> > >  	chip->port = tcpci_get_tcpm_port(chip->tcpci);
> > >  
> > > -	ret = max_tcpci_init_alert(chip, client);
> > > +	name = devm_kasprintf(&client->dev, GFP_KERNEL, "%s-%s",
> > > +			      dev_name(&client->dev), client->name);
> > > +	if (!name)
> > > +		return -ENOMEM;
> > 
> > Please always test your code before sending it out.  You just leaked a
> > bunch of stuff here :(
> 
> Thanks for the review!
> 
> I can not see what leak you're referring to. Could you please clarify?

At a quick glance, tcpci_register_port() is called earlier in the
function, but when you error out here you did not call
tcpci_unregister_port().  What else needs to also be unwound?

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ