linux-kernel - Re: [PATCH v2 2/4] drm/msm/dsi: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26p4fibtwqoiagzce7r46dumwzwe3swyjyy7wddreeksz5kg4i@sbys6hoqye5a>
Date: Fri, 14 Feb 2025 17:23:45 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Rob Clark <robdclark@...il.com>, 
	Abhinav Kumar <quic_abhinavk@...cinc.com>, Sean Paul <sean@...rly.run>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] drm/msm/dsi: Simplify with dev_err_probe()

On Fri, Feb 14, 2025 at 02:17:45PM +0100, Krzysztof Kozlowski wrote:
> dsi_get_config(), dsi_clk_init() and msm_dsi_host_init() are called only
> from platform driver probe function, so using dev_err_probe() is both
> appropriate and beneficial:
>  - Properly marks device deferred probe status,
>  - Avoids dmesg flood on probe deferrals,
>  - Already incorporates printing ERR value,
>  - Shows device name (in contrast to pr_err()),
>  - Makes code smaller and simpler.
> 
> Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Changes in v2:
> 1. Update commit msg
> 2. Tags
> ---
>  drivers/gpu/drm/msm/dsi/dsi_host.c | 100 +++++++++++++++----------------------
>  1 file changed, 41 insertions(+), 59 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

-- 
With best wishes
Dmitry