linux-kernel - Re: [PATCH v3 2/7] reset: mpfs: use the auxiliary device creation helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=VeSrZktEbxNXXTgD80QGTpW5b-WiXUFko+a8FUzmN+fQ@mail.gmail.com>
Date: Fri, 14 Feb 2025 07:25:59 -0800
From: Doug Anderson <dianders@...omium.org>
To: Jerome Brunet <jbrunet@...libre.com>
Cc: Conor Dooley <conor@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Dave Ertman <david.m.ertman@...el.com>, Ira Weiny <ira.weiny@...el.com>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Stephen Boyd <sboyd@...nel.org>, Arnd Bergmann <arnd@...db.de>, 
	Danilo Krummrich <dakr@...nel.org>, Conor Dooley <conor.dooley@...rochip.com>, 
	Daire McNamara <daire.mcnamara@...rochip.com>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Robert Foss <rfoss@...nel.org>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>, 
	Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Hans de Goede <hdegoede@...hat.com>, Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
	"Bryan O'Donoghue" <bryan.odonoghue@...aro.org>, 
	Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>, 
	Gregory CLEMENT <gregory.clement@...tlin.com>, Théo Lebrun <theo.lebrun@...tlin.com>, 
	Michael Turquette <mturquette@...libre.com>, Abel Vesa <abelvesa@...nel.org>, 
	Peng Fan <peng.fan@....com>, Shawn Guo <shawnguo@...nel.org>, 
	Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
	Fabio Estevam <festevam@...il.com>, Kevin Hilman <khilman@...libre.com>, 
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>, linux-kernel@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, dri-devel@...ts.freedesktop.org, 
	platform-driver-x86@...r.kernel.org, linux-mips@...r.kernel.org, 
	linux-clk@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH v3 2/7] reset: mpfs: use the auxiliary device creation helper

Hi,

On Fri, Feb 14, 2025 at 12:59 AM Jerome Brunet <jbrunet@...libre.com> wrote:
>
> > One think that's always felt a bit meh to me is this id number stuff,
> > I just threw in 666 for meme value.
>
> :)
>
> > The whole thing seems super
> > arbitrary, do any of the users of this helper actually put meaningful
> > values into the id parameter?
>
> In example changes I've sent, no.
>
> In other simple usages (those using container_of()) of the auxiliary
> bus, I think there are a few that uses 0 and 1 for 2 instances.
>
> I guess your question is "do we really need this parameter here ?"
>
> We could remove it and still address 90% of the original target.
>
> Keeping it leaves the door open in case the figure above does not hold
> and it is pretty cheap to do. It could also enable drivers requiring an
> IDA to use the helper, possibly.

FWIW, once you resolve the conflicts in drm-misc with ti-sn65dsi86
you'll need the ID value. ;-)

There was a big-ol' discussion here:

https://lore.kernel.org/r/8c2df6a903f87d4932586b25f1d3bd548fe8e6d1.1729180470.git.geert+renesas@glider.be

I eventually pushed v2 of the patch:

https://lore.kernel.org/r/7a68a0e3f927e26edca6040067fb653eb06efb79.1733840089.git.geert+renesas@glider.be


-Doug