linux-kernel - Re: [PATCH v3 37/37] drm/bridge: ti-sn65dsi86: Use bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Uwq3BZNmESmB0Ra5y-jJCb5bi-UTLknrRhVsUbuVbvCA@mail.gmail.com>
Date: Fri, 14 Feb 2025 08:38:17 -0800
From: Doug Anderson <dianders@...omium.org>
To: Maxime Ripard <mripard@...nel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Robert Foss <rfoss@...nel.org>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>, 
	Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 37/37] drm/bridge: ti-sn65dsi86: Use bridge_state crtc pointer

Hi,

On Thu, Feb 13, 2025 at 6:45 AM Maxime Ripard <mripard@...nel.org> wrote:
>
> The TI sn65dsi86 driver follows the drm_encoder->crtc pointer that is
> deprecated and shouldn't be used by atomic drivers.
>
> This was due to the fact that we did't have any other alternative to
> retrieve the CRTC pointer. Fortunately, the crtc pointer is now provided
> in the bridge state, so we can move to atomic callbacks and drop that
> deprecated pointer usage.
>
> Signed-off-by: Maxime Ripard <mripard@...nel.org>
> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 58 +++++++++++++++++++++++------------
>  1 file changed, 39 insertions(+), 19 deletions(-)

While I'm not an expert on all the concepts addressed in this series,
the patch does look reasonable to me from the point of view of
ti-sn65dsi86. Thus:

Reviewed-by: Douglas Anderson <dianders@...omium.org>

I can confirm that on sc7180-trogdor-coachz that the display still
comes up after this patch:

Tested-by: Douglas Anderson <dianders@...omium.org>