linux-kernel - Re: [PATCH v6 2/3] rust: macros: add macro to easily run KUnit tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ-ks9mz=MaR2wSC5VSeBbyAraC_LedPoxf4A9bEnD5O_ASPYA@mail.gmail.com>
Date: Fri, 14 Feb 2025 13:42:09 -0500
From: Tamir Duberstein <tamird@...il.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: David Gow <davidgow@...gle.com>, Miguel Ojeda <ojeda@...nel.org>, 
	José Expósito <jose.exposito89@...il.com>, 
	Rae Moar <rmoar@...gle.com>, Boqun Feng <boqun.feng@...il.com>, 
	Alex Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>, 
	Benno Lossin <benno.lossin@...ton.me>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, Matt Gilbride <mattgilbride@...gle.com>, 
	Brendan Higgins <brendan.higgins@...ux.dev>, kunit-dev@...glegroups.com, 
	linux-kselftest@...r.kernel.org, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/3] rust: macros: add macro to easily run KUnit tests

On Fri, Feb 14, 2025 at 1:38 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Fri, Feb 14, 2025 at 3:41 PM Tamir Duberstein <tamird@...il.com> wrote:
> >
> > This is a really helpful comment. It got me wondering: can we have
> > host-side unit tests for our proc macros? Code is better than
> > comments, of course.
>
> That makes sense (in fact, e.g. Benno wanted them for pinned-init),
> but I will defer that until we have the new build system to avoid
> adding more things to our plate.
>
> > This makes sense. I wonder if we should think about being able to
> > declare a test that runs both on host and in KUnit.
>
> Yeah, when we originally discussed `#[test]`s (years ago), we wanted
> to have "attributes" or "tags" like `#[test(host, kernel)]`.
>
> But, again, something for later -- I would rather we finally land `#[test]`s.
>
> Cheers,
> Miguel

Works for me. Could you link to issues tracking these, if they exist?

Reviewed-by: Tamir Duberstein <tamird@...il.com>