linux-kernel - Re: [PATCH net-next 1/7] net: hibmcge: Add dump statistics supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7594549d-4f5f-4a46-a1c6-b341fc290a43@huawei.com>
Date: Fri, 14 Feb 2025 10:51:28 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <andrew+netdev@...n.ch>,
	<horms@...nel.org>, <shenjian15@...wei.com>, <wangpeiyang1@...wei.com>,
	<liuyonglong@...wei.com>, <chenhao418@...wei.com>, <sudongming1@...wei.com>,
	<xujunsheng@...wei.com>, <shiyongbang@...wei.com>, <libaihan@...wei.com>,
	<jonathan.cameron@...wei.com>, <shameerali.kolothum.thodi@...wei.com>,
	<salil.mehta@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/7] net: hibmcge: Add dump statistics supported
 in this module


on 2025/2/14 3:54, Andrew Lunn wrote:
> On Thu, Feb 13, 2025 at 11:55:23AM +0800, Jijie Shao wrote:
>> The driver supports many hw statistics. This patch supports
>> dump statistics through ethtool_ops and ndo.get_stats64().
>>
>> The type of hw statistics register is u32,
>> To prevent the statistics register from overflowing,
>> the driver dump the statistics every 5 minutes
>> in a scheduled task.
> u32 allows the counter to reach 4294967295 before wrapping. So over 5
> minutes, that is around 14,316,557 per second. Say this is your
> received byte counter? That means your line rate cannot be higher than
> 114Mbps? Is this device really only Fast Ethernet?
>
> 	 Andrew


Haha, maybe my formula is wrong and I missed a unit conversion.

Thank you very much for pointing out the error. I'll recalculate the correct value.

Jijie Shao