linux-kernel - Re: [PATCH V2 1/2] rust: module: change author to be a array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250215135229.300420-1-trintaeoitogc@gmail.com>
Date: Sat, 15 Feb 2025 10:52:29 -0300
From: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
To: benno.lossin@...ton.me
Cc: a.hindborg@...nel.org,
	alex.gaynor@...il.com,
	aliceryhl@...gle.com,
	apw@...onical.com,
	arnd@...db.de,
	aswinunni01@...il.com,
	axboe@...nel.dk,
	bhelgaas@...gle.com,
	bjorn3_gh@...tonmail.com,
	boqun.feng@...il.com,
	dakr@...nel.org,
	dwaipayanray1@...il.com,
	ethan.twardy@...il.com,
	fujita.tomonori@...il.com,
	gary@...yguo.net,
	gregkh@...uxfoundation.org,
	joe@...ches.com,
	linux-kernel@...r.kernel.org,
	lukas.bulwahn@...il.com,
	miguel.ojeda.sandonis@...il.com,
	ojeda@...nel.org,
	pbonzini@...hat.com,
	rust-for-linux@...r.kernel.org,
	tmgross@...ch.edu,
	trintaeoitogc@...il.com,
	walmeida@...rosoft.com
Subject: Re: [PATCH V2 1/2] rust: module: change author to be a array

Benno Lossin <benno.lossin@...ton.me> wrote:
> This commit message looks a bit clunky to me, though I am not a native
> speaker. My suggestion would be:
> 
>     Change the type of the `author` field in the `module!` macro from string
>     to string array. This allows multiple authors for a single module as is
>     already possible in C.
>     Additionally, rename the field to `authors` to better reflect this
>     change.
> 
> Feel free to change/adapt anything.
Thanks for your suggestions, in the truth my english is not so good.

> As already mentioned above, I think it makes sense to also rename the
> field to `authors`.
When I maked this change, I thinked in change the field name from author to
authors, but I don't doing this because anothers fields that is a array in
module! macro (firmware and alias) are in singular too.

> You should also change the documentation in this file, there the field
> `author` is listed as "string literal of the author of the kernel
> module.", so it also needs to be updated.
Yes, you is right... I haven't seen this chunk of text 


Thanks,
Guilherme