linux-kernel - Re: [PATCH V2 1/2] rust: module: change author to be a array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32437338-a050-46ec-a09a-faf73a6b477b@proton.me>
Date: Sat, 15 Feb 2025 14:34:36 +0000
From: Benno Lossin <benno.lossin@...ton.me>
To: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
Cc: a.hindborg@...nel.org, alex.gaynor@...il.com, aliceryhl@...gle.com, apw@...onical.com, arnd@...db.de, aswinunni01@...il.com, axboe@...nel.dk, bhelgaas@...gle.com, bjorn3_gh@...tonmail.com, boqun.feng@...il.com, dakr@...nel.org, dwaipayanray1@...il.com, ethan.twardy@...il.com, fujita.tomonori@...il.com, gary@...yguo.net, gregkh@...uxfoundation.org, joe@...ches.com, linux-kernel@...r.kernel.org, lukas.bulwahn@...il.com, miguel.ojeda.sandonis@...il.com, ojeda@...nel.org, pbonzini@...hat.com, rust-for-linux@...r.kernel.org, tmgross@...ch.edu, walmeida@...rosoft.com
Subject: Re: [PATCH V2 1/2] rust: module: change author to be a array

On 15.02.25 14:52, Guilherme Giacomo Simoes wrote:
> Benno Lossin <benno.lossin@...ton.me> wrote:
>> As already mentioned above, I think it makes sense to also rename the
>> field to `authors`.
> When I maked this change, I thinked in change the field name from author to
> authors, but I don't doing this because anothers fields that is a array in
> module! macro (firmware and alias) are in singular too.

Hmm IMO the `alias` field should also probably be called `aliases`
(though not in this patch). And I believe that the plural of `firmware`
also is `firmware`.
So I still think it's a good idea to rename it to `authors`.

>> You should also change the documentation in this file, there the field
>> `author` is listed as "string literal of the author of the kernel
>> module.", so it also needs to be updated.
> Yes, you is right... I haven't seen this chunk of text

No worries, that's what review is for.

---
Cheers,
Benno