linux-kernel - Re: [PATCH] arm64: dts: rockchip: add hdmi1 support to ROCK 5 ITX

Open Source and information security mailing list archives

Message-Id: <566E6F11-765C-4415-8805-55DFD3C2BD4D@gmail.com>
Date: Sun, 16 Feb 2025 13:37:05 +0100
From: Piotr Oniszczuk <piotr.oniszczuk@...il.com>
To: Jianfeng Liu <liujianfeng1994@...il.com>
Cc: linux-rockchip@...ts.infradead.org,
 Conor Dooley <conor+dt@...nel.org>,
 Heiko Stuebner <heiko@...ech.de>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Rob Herring <robh@...nel.org>,
 Stephen Rothwell <sfr@...b.auug.org.au>,
 devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: add hdmi1 support to ROCK 5 ITX

> Wiadomość napisana przez Jianfeng Liu <liujianfeng1994@...il.com> w dniu 15 lut 2025, o godz. 16:25:
> 
> Enable the HDMI port next to ethernet port.
> 
> Signed-off-by: Jianfeng Liu <liujianfeng1994@...il.com>
> ---
> 
> .../boot/dts/rockchip/rk3588-rock-5-itx.dts   | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> index 6d68f70284e..a4fdced052c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> @@ -11,6 +11,7 @@
> #include <dt-bindings/leds/common.h>
> #include <dt-bindings/pinctrl/rockchip.h>
> #include <dt-bindings/pwm/pwm.h>
> +#include <dt-bindings/soc/rockchip,vop2.h>
> #include "dt-bindings/usb/pd.h"
> #include "rk3588.dtsi"
> 
> @@ -89,6 +90,17 @@ fan0: pwm-fan {
> pwms = <&pwm14 0 10000 0>;
> };
> 
> + hdmi1-con {
> + compatible = "hdmi-connector";
> + type = "a";
> +
> + port {
> + hdmi1_con_in: endpoint {
> + remote-endpoint = <&hdmi1_out_con>;
> + };
> + };
> + };
> +
> /* M.2 E-KEY */
> sdio_pwrseq: sdio-pwrseq {
> compatible = "mmc-pwrseq-simple";
> @@ -261,6 +273,32 @@ &gpu {
> status = "okay";
> };
> 
> +&hdmi1 {
> + pinctrl-0 = <&hdmim0_tx1_cec &hdmim0_tx1_hpd
> +     &hdmim1_tx1_scl &hdmim1_tx1_sda>;
> + status = "okay";
> +};
> +
> +&hdmi1_in {
> + hdmi1_in_vp1: endpoint {
> + remote-endpoint = <&vp1_out_hdmi1>;
> + };
> +};
> +
> +&hdmi1_out {
> + hdmi1_out_con: endpoint {
> + remote-endpoint = <&hdmi1_con_in>;
> + };
> +};
> +
> +&hdptxphy_hdmi0 {
> + status = "okay";
> +};
> +
> +&hdptxphy1 {
> + status = "okay";
> +};
> +
> &i2c0 {
> pinctrl-names = "default";
> pinctrl-0 = <&i2c0m2_xfer>;
> @@ -1209,3 +1247,18 @@ &usbdp_phy1 {
> rockchip,dp-lane-mux = <2 3>;
> status = "okay";
> };
> +
> +&vop {
> + status = "okay";
> +};
> +
> +&vop_mmu {
> + status = "okay";
> +};
> +
> +&vp1 {
> + vp1_out_hdmi1: endpoint@...KCHIP_VOP2_EP_HDMI1 {
> + reg = <ROCKCHIP_VOP2_EP_HDMI1>;
> + remote-endpoint = <&hdmi1_in_vp1>;
> + };
> +};
> -- 
> 2.43.0
> 
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

Jianfeng,

Is there anywhere repo with this patch applied to test it on rock5 itx hw?

(asking as I can’t get it working; even with hdmi1 only vop clocks like here: https://gist.github.com/warpme/49feadbe1f53ea31fca76f41d5bb3ee4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives