linux-kernel - Re: [PATCH 3/4] x86/tdx: Add tdx_mcall_rtmr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <307d7655-1857-4662-b77f-86f402b6d046@linux.intel.com>
Date: Mon, 17 Feb 2025 13:39:17 -0800
From: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@...ux.intel.com>
To: "Xing, Cedric" <cedric.xing@...el.com>, "Huang, Kai"
 <kai.huang@...el.com>, Dan Williams <dan.j.williams@...el.com>,
 "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, x86@...nel.org,
 "H. Peter Anvin" <hpa@...or.com>
Cc: linux-kernel@...r.kernel.org, linux-coco@...ts.linux.dev
Subject: Re: [PATCH 3/4] x86/tdx: Add tdx_mcall_rtmr_extend() interface

On 2/17/25 12:58 PM, Xing, Cedric wrote:
> On 2/16/2025 6:40 PM, Huang, Kai wrote:
>>
>>> @@ -135,6 +136,41 @@ int tdx_mcall_get_report0(u8 *reportdata, u8 
>>> *tdreport)
>>>   }
>>>   EXPORT_SYMBOL_GPL(tdx_mcall_get_report0);
>>> +/**
>>> + * tdx_mcall_rtmr_extend() - Wrapper to extend RTMR registers using
>>> + *                 TDG.MR.RTMR.EXTEND TDCALL.
>>
>> Nit:  I would prefer to name it as tdx_mcall_extend_rtmr() since this 
>> matches the existing tdx_mcall_get_report0() (and 
>> tdx_hcall_get_quote()) better.  But no strong opinion.
>>
> This actually my preference too!
>
> Sathy, what do you think?

I have used rtmr_extend() to match with TDCALL name. But I am fine with 
tdx_mcall_extend_rtmr(). We can use it.

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer