linux-kernel - RE: [PATCH v2 01/16] x86/mce: Don't remove sysfs if thresholding sysfs init fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB7134FB62A26B7E96A40BDDD989FB2@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Mon, 17 Feb 2025 06:58:00 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Yazen Ghannam <yazen.ghannam@....com>, "x86@...nel.org" <x86@...nel.org>,
	"Luck, Tony" <tony.luck@...el.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"Smita.KoralahalliChannabasappa@....com"
	<Smita.KoralahalliChannabasappa@....com>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>
Subject: RE: [PATCH v2 01/16] x86/mce: Don't remove sysfs if thresholding
 sysfs init fails

> From: Yazen Ghannam <yazen.ghannam@....com>
> Sent: Friday, February 14, 2025 12:46 AM
> To: x86@...nel.org; Luck, Tony <tony.luck@...el.com>
> Cc: linux-kernel@...r.kernel.org; linux-edac@...r.kernel.org;
> Smita.KoralahalliChannabasappa@....com; Yazen Ghannam
> <yazen.ghannam@....com>; stable@...r.kernel.org
> Subject: [PATCH v2 01/16] x86/mce: Don't remove sysfs if thresholding sysfs
> init fails
> 
> Currently, the MCE subsystem sysfs interface will be removed if the
> thresholding sysfs interface fails to be created. A common failure is due to
> new MCA bank types that are not recognized and don't have a short name
> set.
> 
> The MCA thresholding feature is optional and should not break the common
> MCE sysfs interface. Also, new MCA bank types are occasionally introduced,
> and updates will be needed to recognize them. But likewise, this should not
> break the common sysfs interface.
> 
> Keep the MCE sysfs interface regardless of the status of the thresholding sysfs
> interface.
> 
> Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>
> Cc: stable@...r.kernel.org

LGTM.
    Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>