linux-kernel - RE: [PATCH v2 02/16] x86/mce/amd: Remove return value for mce_threshold_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB71345FB3EA6A7AE492D62E5589FB2@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Mon, 17 Feb 2025 07:11:52 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Yazen Ghannam <yazen.ghannam@....com>, "x86@...nel.org" <x86@...nel.org>,
	"Luck, Tony" <tony.luck@...el.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"Smita.KoralahalliChannabasappa@....com"
	<Smita.KoralahalliChannabasappa@....com>
Subject: RE: [PATCH v2 02/16] x86/mce/amd: Remove return value for
 mce_threshold_create_device()

> From: Yazen Ghannam <yazen.ghannam@....com>
> Sent: Friday, February 14, 2025 12:46 AM
> To: x86@...nel.org; Luck, Tony <tony.luck@...el.com>
> Cc: linux-kernel@...r.kernel.org; linux-edac@...r.kernel.org;
> Smita.KoralahalliChannabasappa@....com; Yazen Ghannam
> <yazen.ghannam@....com>
> Subject: [PATCH v2 02/16] x86/mce/amd: Remove return value for
> mce_threshold_create_device()
> 
> The return value is no longer checked, so set return type to 'void'.
>

This change can also be applied to mce_threshold_remove_device().

> Also, move function declarations to internal.h, since this function is only used
> within the MCE subsystem.

This change can also be applied to mce_threshold_remove_device().

So, can we also apply the two changes above for mce_threshold_remove_device() 
in this patch?

-Qiuxu