linux-kernel - [PATCH v3] cgroup/cpuset: fmeter_getrate() returns 0 when memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250217071500.1947773-1-guojie.jin@gmail.com>
Date: Mon, 17 Feb 2025 07:15:00 +0000
From: Jin Guojie <guojie.jin@...il.com>
To: cgroups@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: Jin Guojie <guojie.jin@...il.com>,
	Michal Koutný <mkoutny@...e.com>,
	Waiman Long <longman@...hat.com>
Subject: [PATCH v3] cgroup/cpuset: fmeter_getrate() returns 0 when memory_pressure disabled

When running LTP's cpuset_memory_pressure program, an error can be
reproduced by the following steps:

(1) Create a cgroup, enable cpuset subsystem, set memory limit, and
then set cpuset_memory_pressure to 1
(2) In this cgroup, create a process to allocate a large amount of
memory and generate pressure counts
(3) Set cpuset_memory_pressure to 0
(4) Check cpuset.memory_pressure: LTP thinks it should be 0, but the
kernel returns a value of 1, so LTP determines it as FAIL

In the current kernel, the variable cpuset_memory_pressure_enabled is
not actually used。

This patch modifies fmeter_getrate() to determine whether to return 0
based on cpuset_memory_pressure_enabled.

Signed-off-by: Jin Guojie <guojie.jin@...il.com>
Suggested-by: Michal Koutný <mkoutny@...e.com>
Suggested-by: Waiman Long <longman@...hat.com>
---
 kernel/cgroup/cpuset-v1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c
index 25c1d7b77e2f..14564e91e2b3 100644
--- a/kernel/cgroup/cpuset-v1.c
+++ b/kernel/cgroup/cpuset-v1.c
@@ -108,7 +108,7 @@ static int fmeter_getrate(struct fmeter *fmp)
 	fmeter_update(fmp);
 	val = fmp->val;
 	spin_unlock(&fmp->lock);
-	return val;
+	return cpuset_memory_pressure_enabled ? val : 0;
 }
 
 /*
-- 
2.34.1