linux-kernel - Re: [PATCH v2 2/2] usb: xhci: Fix unassigned variable 'bcdUSB' in xhci_create_usb3x_bos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025021701-cofounder-flock-2165@gregkh>
Date: Mon, 17 Feb 2025 08:17:24 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Selvarasu Ganesan <selvarasu.g@...sung.com>
Cc: mathias.nyman@...el.com, WeitaoWang-oc@...oxin.com,
	Thinh.Nguyen@...opsys.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, jh0801.jung@...sung.com,
	dh10.jung@...sung.com, naushad@...sung.com, akash.m5@...sung.com,
	h10.kim@...sung.com, eomji.oh@...sung.com, alim.akhtar@...sung.com,
	thiagu.r@...sung.com, muhammed.ali@...sung.com,
	pritam.sutar@...sung.com, cpgs@...sung.com, stable@...r.kernel.org
Subject: Re: [PATCH v2 2/2] usb: xhci: Fix unassigned variable 'bcdUSB' in
 xhci_create_usb3x_bos_desc()

On Mon, Feb 17, 2025 at 12:19:51PM +0530, Selvarasu Ganesan wrote:
> 
> On 2/14/2025 1:35 PM, Greg KH wrote:
> > On Thu, Feb 13, 2025 at 09:51:26AM +0530, Selvarasu Ganesan wrote:
> >> Fix the following smatch error:
> >> drivers/usb/host/xhci-hub.c:71 xhci_create_usb3x_bos_desc() error: unassigned variable 'bcdUSB'
> > That really doesn't say what is happening here at all.  Please provide a
> > lot more information as the response from a tool could, or could not, be
> > a real issue, how are we supposed to know?
> >
> > And "unassigned" really isn't the bug that is being fixed here, please
> > describe it better.
> >
> > Same for patch 2 of the series.
> >
> > Also, your 0/2 email was not threaded with these patches, something odd
> > happened in your email setup, you might want to look into that.
> >
> > thanks,
> >
> > greg k-h
> >
> 
> Hi Greg,
> 
> I understand your concern about whether the response from the tool could 
> be a real issue or not. However, please check the provided code, I 
> believe there is an issue worth considering.

I am not disagreeing that this is a real issue that should be fixed (but
confused as to why the normal compilers are not catching this, which
implies that maybe it never can actually be hit).

So please fix up your changelog text and I will be glad to review it.

thanks,

greg k-h